Skip to content

[Bug][Refactor][issue-3157]use cas to avoid thread safe problem#3158

Merged
lgcareer merged 2 commits intoapache:devfrom
tswstarplanet:atomic_instance_lock
Jul 7, 2020
Merged

[Bug][Refactor][issue-3157]use cas to avoid thread safe problem#3158
lgcareer merged 2 commits intoapache:devfrom
tswstarplanet:atomic_instance_lock

Conversation

@tswstarplanet
Copy link
Copy Markdown
Contributor

fix #3157

Tips

What is the purpose of the pull request

(For example: This pull request adds checkstyle plugin.)

Brief change log

(for example:)

  • Add maven-checkstyle-plugin to root pom.xml

Verify this pull request

(Please pick either of the following options)

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added dolphinscheduler-dao tests for end-to-end.
  • Added CronUtilsTest to verify the change.
  • Manually verified the change by testing locally.

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

@lgcareer lgcareer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #3158 into dev will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #3158      +/-   ##
============================================
- Coverage     33.55%   33.50%   -0.06%     
+ Complexity     2397     2393       -4     
============================================
  Files           442      442              
  Lines         20614    20612       -2     
  Branches       2524     2524              
============================================
- Hits           6918     6907      -11     
- Misses        13035    13046      +11     
+ Partials        661      659       -2     
Impacted Files Coverage Δ Complexity Δ
...e/dolphinscheduler/remote/NettyRemotingServer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) 0.00% <0.00%> (-3.00%)
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 9.00% <0.00%> (-1.00%)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) 25.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d6ade...47ba8e8. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@lgcareer lgcareer merged commit bf3cc0d into apache:dev Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] netty server may start multiple times if multiple threads execute the start method

4 participants