[Feature-2930][api] Displays path and host on the instance log panel. #2930#3154
Merged
qiaozhanwei merged 17 commits intoapache:devfrom Jul 23, 2020
Merged
[Feature-2930][api] Displays path and host on the instance log panel. #2930#3154qiaozhanwei merged 17 commits intoapache:devfrom
qiaozhanwei merged 17 commits intoapache:devfrom
Conversation
…duler into feature-2930
Contributor
|
down load task log is also add this |
Comment on lines
+78
to
+79
| StringBuilder log = new StringBuilder(); | ||
| if(skipLineNum == 0 ) { |
Contributor
There was a problem hiding this comment.
Suggested change
| StringBuilder log = new StringBuilder(); | |
| if(skipLineNum == 0 ) { | |
| StringBuilder log = new StringBuilder(); | |
| if (skipLineNum == 0) { |
Hi,
Good job and thx a lot for your contribution, please configure the checkstyle.xml[1] to IDE and it will help to format code.
[1] https://github.com/apache/incubator-dolphinscheduler/tree/dev/style
Contributor
|
Hi, |
Contributor
|
Hi, Thx a lot for your contribution. |
Contributor
|
please resolve conflicting files. Thx |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #2930.