Skip to content

optimize SchedulerService.setScheduleState code#3136

Merged
davidzollo merged 17 commits intoapache:devfrom
samz406:schedule
Jul 12, 2020
Merged

optimize SchedulerService.setScheduleState code#3136
davidzollo merged 17 commits intoapache:devfrom
samz406:schedule

Conversation

@samz406
Copy link
Copy Markdown
Contributor

@samz406 samz406 commented Jul 5, 2020

What is the purpose of the pull request

1 simple optimize SchedulerService.setScheduleState code,Mainly remove unnecessary queries

2 modify SchedulerServiceTest the test case to PowerMock

no issue

@samz406 samz406 requested a review from qiaozhanwei July 5, 2020 08:49
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo requested a review from lenboo July 6, 2020 14:28
Copy link
Copy Markdown
Contributor

@lgcareer lgcareer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

@davidzollo davidzollo added the enhancement New feature or request label Jul 12, 2020
@davidzollo davidzollo merged commit 6fa3701 into apache:dev Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants