Skip to content

add maxWaitTime config when build zookeeper client#3133

Merged
qiaozhanwei merged 7 commits intoapache:devfrom
tswstarplanet:zk_block_time
Jul 9, 2020
Merged

add maxWaitTime config when build zookeeper client#3133
qiaozhanwei merged 7 commits intoapache:devfrom
tswstarplanet:zk_block_time

Conversation

@tswstarplanet
Copy link
Copy Markdown
Contributor

@tswstarplanet tswstarplanet commented Jul 5, 2020

#3138

Tips

What is the purpose of the pull request

This pr can make the app avoid blocking when the curator zookeeper client cannot connect to Zookeeper server.

Brief change log

  • Add max.wait.time config to zookeeper config
  • Use the blockUntilConnected method with parameter 'maxWaitTime' instead that without the parameter

Verify this pull request

(Please pick either of the following options)

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added dolphinscheduler-dao tests for end-to-end.
  • Added CronUtilsTest to verify the change.
  • Manually verified the change by testing locally.

@yangyichao-mango
Copy link
Copy Markdown
Contributor

Good job,

Can you link this PR to a trackable issue and change the description of commit message according to the specification of commit message?

Copy link
Copy Markdown
Contributor

@lgcareer lgcareer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! +1

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@qiaozhanwei qiaozhanwei merged commit d87d2d8 into apache:dev Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] The app will try to reconnect the zookeeper server when it fails to initiate the connection.

5 participants