Skip to content

[Feature-#3083]Select and drag dag#3068

Merged
lenboo merged 3 commits intoapache:devfrom
satcblue:selectAndDragDag
Jul 2, 2020
Merged

[Feature-#3083]Select and drag dag#3068
lenboo merged 3 commits intoapache:devfrom
satcblue:selectAndDragDag

Conversation

@satcblue
Copy link
Copy Markdown
Contributor

@satcblue satcblue commented Jun 28, 2020 •
edited
Loading

Support to multi drag task

What is the purpose of the pull request

  • Convenient for users to drag and drop, when user use the dag, he should drag one by one. Now, he can select one or more to drag by pressing the key of 'ctrl' or 'meta'.

Brief change log

  • Add multiDrag.js

@break60
Copy link
Copy Markdown
Contributor

break60 commented Jun 29, 2020

Please don't change the code style of dag.vue page, otherwise I don't know what you changed

@yangyichao-mango
Copy link
Copy Markdown
Contributor

yangyichao-mango commented Jun 29, 2020

Good job,
We should commit an issue before we do this work. Can you commit a new feature issue about your work and link this PR to that issue?

@satcblue
Copy link
Copy Markdown
Contributor Author

satcblue commented Jun 30, 2020

Please don't change the code style of dag.vue page, otherwise I don't know what you changed

sorry about that, i will redo dag.vue page.

@satcblue
Copy link
Copy Markdown
Contributor Author

satcblue commented Jun 30, 2020

Good job,
We should commit an issue before we do this work. Can you commit a new feature issue about your work and link this PR to that issue?

thx, get it. it's my first time to create PR. I will recheck my code these days, then commit a new feature issue.

@satcblue satcblue mentioned this pull request Jun 30, 2020
Closed
@satcblue
Copy link
Copy Markdown
Contributor Author

satcblue commented Jun 30, 2020

Good job,
We should commit an issue before we do this work. Can you commit a new feature issue about your work and link this PR to that issue?

thx, get it. it's my first time to create PR. I will recheck my code these days, then commit a new feature issue.

done

@break60
Copy link
Copy Markdown
Contributor

break60 commented Jun 30, 2020

Good job,
We should commit an issue before we do this work. Can you commit a new feature issue about your work and link this PR to that issue?

thx, get it. it's my first time to create PR. I will recheck my code these days, then commit a new feature issue.

done

I don’t see your associated issue, please give an issue to describe this function, and then connect to this pr

@satcblue
Copy link
Copy Markdown
Contributor Author

satcblue commented Jun 30, 2020 •
edited
Loading

Good job,
We should commit an issue before we do this work. Can you commit a new feature issue about your work and link this PR to that issue?

thx, get it. it's my first time to create PR. I will recheck my code these days, then commit a new feature issue.

done

I don’t see your associated issue, please give an issue to describe this function, and then connect to this pr

like this? #3083

@break60
Copy link
Copy Markdown
Contributor

break60 commented Jun 30, 2020

very good， front end +1

@satcblue satcblue changed the title Select and drag dag [Feature-#3083]Select and drag dag Jun 30, 2020
@lenboo
Copy link
Copy Markdown
Contributor

lenboo commented Jul 2, 2020

very good， front end +1

you can Approve +1 at “File Changed”

lenboo
lenboo approved these changes Jul 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lenboo lenboo merged commit b0a7bb4 into apache:dev Jul 2, 2020
@davidzollo davidzollo linked an issue Jul 2, 2020 that may be closed by this pull request
[Feature]support multi drag dag nodes #3083
Closed
@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented Jul 2, 2020

thanks for your first contribution, if you need help, please contact dev@dolphinscheduler.apache.org or wechat(510570367), when added, please tell your github id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenboo lenboo lenboo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]support multi drag dag nodes

5 participants

@satcblue @break60 @yangyichao-mango @lenboo @davidzollo