Skip to content

NettyDecoder class decode method switch case remove break#3035

Merged
Technoboy- merged 101 commits intoapache:devfrom
qiaozhanwei:dev
Jul 10, 2020
Merged

NettyDecoder class decode method switch case remove break#3035
Technoboy- merged 101 commits intoapache:devfrom
qiaozhanwei:dev

Conversation

@qiaozhanwei
Copy link
Copy Markdown
Contributor

revert #2969 PR

please refer netty source code ReplayingDecoder or https://www.jianshu.com/p/1f27eaea611d

qiaozhanwei and others added 30 commits April 13, 2020 15:43
2,worker response task status sync wait for result
2,worker response task status sync wait for result
2,worker response task status sync wait for result
2,worker response task status sync wait for result
2,worker response task status sync wait for result
2,worker response task status sync wait for result
2,worker response task status sync wait for result
2,worker response task status sync wait for result
2,worker response task status sync wait for result
2,worker response task status sync wait for result
2,worker response task status sync wait for result
@xsbai93 xsbai93 mentioned this pull request Jun 29, 2020
@qiaozhanwei qiaozhanwei changed the title revert #2969 NettyDecoder class decode method switch case remove break Jun 30, 2020
@qiaozhanwei qiaozhanwei requested a review from Technoboy- July 9, 2020 12:23
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #3035 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #3035   +/-   ##
=========================================
  Coverage     33.51%   33.52%           
  Complexity     2394     2394           
=========================================
  Files           442      442           
  Lines         20616    20611    -5     
  Branches       2525     2525           
=========================================
  Hits           6909     6909           
+ Misses        13048    13043    -5     
  Partials        659      659           
Impacted Files Coverage Δ Complexity Δ
...he/dolphinscheduler/remote/codec/NettyDecoder.java 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d87d2d8...10557a7. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants