Skip to content

Fix #3018 [BUG_i18n incomplete] #3022

Merged
davidzollo merged 3 commits intoapache:devfrom
xsbai93:dev
Jun 20, 2020
Merged

Fix #3018 [BUG_i18n incomplete] #3022
davidzollo merged 3 commits intoapache:devfrom
xsbai93:dev

Conversation

@xsbai93
Copy link
Copy Markdown
Contributor

@xsbai93 xsbai93 commented Jun 19, 2020

Tips

What is the purpose of the pull request

Fix Issue #3018

Brief change log

modified the filed of 'user type' in dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/list.vue
add translate to dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js
add translate to dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js

Verify this pull request

This pull request is code cleanup without any test coverage.

@xsbai93 xsbai93 changed the title 修复了#3018 [BUG_i18n 不完整]的问题 Fix #3018 [BUG_i18n incomplete] Jun 19, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

good job
thanks for your first contribution, looking forward for your next contribution.
if you need help, please send me a short message through wetchat(510570367) or mail(dev@dolphinscheduler.apache.org). when added, please tell me your github id, thx

@davidzollo davidzollo linked an issue Jun 20, 2020 that may be closed by this pull request
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 6e0b464 into apache:dev Jun 20, 2020
@davidzollo davidzollo added the bug Something isn't working label Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] i18n incomplete

3 participants