Skip to content

Fix bug #2991 duplicate key: DOLPHIN_ALERT#2993

Merged
davidzollo merged 3 commits intoapache:devfrom
Erik-ly:dev
Jun 17, 2020
Merged

Fix bug #2991 duplicate key: DOLPHIN_ALERT#2993
davidzollo merged 3 commits intoapache:devfrom
Erik-ly:dev

Conversation

@Erik-ly
Copy link
Copy Markdown
Contributor

@Erik-ly Erik-ly commented Jun 16, 2020

edit duplicate DOLPHIN_ALERT and label

Erik-ly added 2 commits June 16, 2020 15:19
edit duplicate DOLPHIN_ALERT and label
Fix bug #2991 duplicate key: DOLPHIN_ALERT
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2993 into dev will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2993      +/-   ##
============================================
- Coverage     39.31%   39.13%   -0.18%     
+ Complexity     2700     2690      -10     
============================================
  Files           435      435              
  Lines         20123    20123              
  Branches       2453     2453              
============================================
- Hits           7912     7876      -36     
- Misses        11458    11494      +36     
  Partials        753      753              
Impacted Files Coverage Δ Complexity Δ
.../server/worker/processor/TaskExecuteProcessor.java 10.16% <0.00%> (-27.12%) 1.00% <0.00%> (-2.00%)
...nscheduler/server/entity/TaskExecutionContext.java 89.10% <0.00%> (-9.91%) 61.00% <0.00%> (-5.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 68.25% <0.00%> (-9.53%) 13.00% <0.00%> (-1.00%)
...org/apache/dolphinscheduler/remote/utils/Host.java 28.57% <0.00%> (-5.72%) 6.00% <0.00%> (-1.00%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.95% <0.00%> (-1.44%) 10.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8031c16...99b44bc. Read the comment docs.

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@davidzollo
Copy link
Copy Markdown
Contributor

thanks for your first contribution, looking forward your next contribution.
if you meet any problem, please send mail to dev@dolphinscheduler.apachr.org or my wechat(510570367), when added, please tell me your github id, thx

@davidzollo davidzollo merged commit eef3976 into apache:dev Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants