Skip to content

Alternative #2832 Pull requests.#2970

Merged
gabry-lab merged 2 commits intoapache:devfrom
743294668:Toms
Jun 15, 2020
Merged

Alternative #2832 Pull requests.#2970
gabry-lab merged 2 commits intoapache:devfrom
743294668:Toms

Conversation

@743294668
Copy link
Copy Markdown
Contributor

Due to the accidental deletion of the previous warehouse, #2832 cannot be merged, causing trouble to everyone, I am sorry. Now, I resubmit it and the revised content is exactly the same as #2832. I also hope that everyone will spare no effort to help review, thank you.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 14, 2020

Codecov Report

Merging #2970 into dev will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2970      +/-   ##
============================================
+ Coverage     39.11%   39.36%   +0.24%     
- Complexity     2678     2699      +21     
============================================
  Files           435      435              
  Lines         20119    20121       +2     
  Branches       2454     2453       -1     
============================================
+ Hits           7870     7921      +51     
+ Misses        11514    11445      -69     
- Partials        735      755      +20     
Impacted Files Coverage Δ Complexity Δ
...olphinscheduler/dao/datasource/BaseDataSource.java 50.00% <ø> (+50.00%) 15.00 <0.00> (+15.00)
...olphinscheduler/api/service/DataSourceService.java 7.27% <100.00%> (+5.05%) 5.00 <0.00> (+2.00)
...phinscheduler/dao/datasource/OracleDataSource.java 90.90% <100.00%> (+90.90%) 6.00 <2.00> (+6.00)
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.07% <0.00%> (-2.88%) 9.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a7fd72...6ba2378. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@743294668 743294668 changed the title Modify OracleDB connection string format. Alternative #2832 Pull requests. Jun 15, 2020
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants