Skip to content

first show: remove unnecessary code#2968

Merged
gabry-lab merged 1 commit intoapache:devfrom
superScala:firstShow
Jun 14, 2020
Merged

first show: remove unnecessary code#2968
gabry-lab merged 1 commit intoapache:devfrom
superScala:firstShow

Conversation

@superScala
Copy link
Copy Markdown
Contributor

@superScala superScala commented Jun 14, 2020

What is the purpose of the pull request

remove unnecessary code

Brief change log

  • remove unnecessary code from NettyRemotingServer.java

@superScala
Copy link
Copy Markdown
Contributor Author

superScala commented Jun 14, 2020

Who can help to review this PR which is a simple PR and can go through quickly

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 14, 2020

Codecov Report

Merging #2968 into dev will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2968      +/-   ##
============================================
- Coverage     39.30%   39.11%   -0.20%     
+ Complexity     2689     2678      -11     
============================================
  Files           435      435              
  Lines         20120    20119       -1     
  Branches       2455     2454       -1     
============================================
- Hits           7909     7870      -39     
- Misses        11473    11514      +41     
+ Partials        738      735       -3
Impacted Files Coverage Δ Complexity Δ
...e/dolphinscheduler/remote/NettyRemotingServer.java 77.41% <100.00%> (+1.22%) 7.00 <0.00> (ø)
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) 0.00% <0.00%> (-3.00%)
.../server/worker/processor/TaskExecuteProcessor.java 10.16% <0.00%> (-27.12%) 1.00% <0.00%> (-2.00%)
...nscheduler/server/entity/TaskExecutionContext.java 89.10% <0.00%> (-9.91%) 61.00% <0.00%> (-5.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 68.25% <0.00%> (-6.35%) 13.00% <0.00%> (-1.00%)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) 25.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e7403e...625040f. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

gabry-lab
gabry-lab approved these changes Jun 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@superScala defaultExecutor always has a object and can't be null, good first show, congratulations

@gabry-lab gabry-lab merged commit 3a7fd72 into apache:dev Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gabry-lab gabry-lab gabry-lab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@superScala @codecov-commenter @gabry-lab