Skip to content

[Feature-2927][common] Fix NEF when get info from OSUtils (#2927)#2964

Merged
gabry-lab merged 4 commits intoapache:devfrom
yangyichao-mango:feature-2927
Jun 14, 2020
Merged

[Feature-2927][common] Fix NEF when get info from OSUtils (#2927)#2964
gabry-lab merged 4 commits intoapache:devfrom
yangyichao-mango:feature-2927

Conversation

@yangyichao-mango
Copy link
Copy Markdown
Contributor

@yangyichao-mango yangyichao-mango commented Jun 13, 2020

What is the purpose of the pull request

Fix NEF when get info from OSUtils.

Brief change log

  • Add Double.isNaN check to OSUtils.memoryUsage(), OSUtils.availablePhysicalMemorySize(), OSUtils.totalMemorySize(), OSUtils.loadAverage(), OSUtils.cpuUsage().

Verify this pull request

This pull request is already covered by existing tests, such as OSUtilsTest.testOSMetric().

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 13, 2020 •
edited
Loading

Codecov Report

Merging #2964 into dev will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2964      +/-   ##
============================================
- Coverage     39.29%   39.12%   -0.17%     
+ Complexity     2688     2678      -10     
============================================
  Files           435      435              
  Lines         20116    20120       +4     
  Branches       2453     2455       +2     
============================================
- Hits           7904     7872      -32     
- Misses        11476    11508      +32     
- Partials        736      740       +4
Impacted Files Coverage Δ Complexity Δ
.../apache/dolphinscheduler/common/utils/OSUtils.java 48.32% <0.00%> (-1.34%) 23.00 <0.00> (ø)
.../server/worker/processor/TaskExecuteProcessor.java 10.16% <0.00%> (-27.12%) 1.00% <0.00%> (-2.00%)
...nscheduler/server/entity/TaskExecutionContext.java 89.10% <0.00%> (-9.91%) 61.00% <0.00%> (-5.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 68.25% <0.00%> (-3.18%) 13.00% <0.00%> (-1.00%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.07% <0.00%> (-2.88%) 9.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd7289...8ddf9bb. Read the comment docs.

@yangyichao-mango
Copy link
Copy Markdown
Contributor Author

yangyichao-mango commented Jun 13, 2020

Hi @gabrywu . Can you help to review this PR?

@yangyichao-mango
Update OSUtils.java
602c50d 
Change java doc
@gabry-lab
Copy link
Copy Markdown
Member

gabry-lab commented Jun 13, 2020

@yangyichao-mango can you resolve the e2e Test errors before the PR could be merged ?

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

gabry-lab
gabry-lab approved these changes Jun 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gabry-lab gabry-lab merged commit 0e7403e into apache:dev Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gabry-lab gabry-lab gabry-lab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yangyichao-mango @codecov-commenter @gabry-lab