Skip to content

add http task timeout & test unit#2955

Merged
davidzollo merged 3 commits intoapache:devfrom
BoYiZhang:dev
Jun 12, 2020
Merged

add http task timeout & test unit#2955
davidzollo merged 3 commits intoapache:devfrom
BoYiZhang:dev

Conversation

@BoYiZhang
Copy link
Copy Markdown
Contributor

image

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #2955 into dev will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2955      +/-   ##
============================================
+ Coverage     38.13%   38.46%   +0.32%     
- Complexity     2620     2653      +33     
============================================
  Files           436      436              
  Lines         20084    20090       +6     
  Branches       2444     2444              
============================================
+ Hits           7660     7727      +67     
+ Misses        11714    11640      -74     
- Partials        710      723      +13     
Impacted Files Coverage Δ Complexity Δ
...phinscheduler/common/task/http/HttpParameters.java 96.00% <100.00%> (+85.47%) 16.00 <4.00> (+15.00)
...hinscheduler/server/worker/task/http/HttpTask.java 44.24% <100.00%> (+44.24%) 15.00 <1.00> (+15.00)
.../server/worker/processor/TaskExecuteProcessor.java 10.16% <0.00%> (-27.12%) 1.00% <0.00%> (-2.00%)
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 9.00% <0.00%> (-1.00%)
...nscheduler/server/entity/TaskExecutionContext.java 89.10% <0.00%> (-3.97%) 61.00% <0.00%> (-2.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 74.60% <0.00%> (-3.18%) 14.00% <0.00%> (-1.00%)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) 25.00% <0.00%> (ø%)
...ache/dolphinscheduler/server/utils/ParamUtils.java 70.73% <0.00%> (+7.31%) 10.00% <0.00%> (+1.00%)
...dolphinscheduler/server/worker/task/TaskProps.java 23.17% <0.00%> (+17.07%) 11.00% <0.00%> (+7.00%)
...lphinscheduler/common/task/AbstractParameters.java 72.72% <0.00%> (+27.27%) 5.00% <0.00%> (+1.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284c50f...ea98a74. Read the comment docs.

@gabry-lab
Copy link
Copy Markdown
Member

gabry-lab commented Jun 12, 2020

@BoYiZhang Why is the default value of connecTimeout & socketTimeout set through front-end?
I think this is not a good solution, it's better set in backend.
Let's say, somebody create the dag through the Restful API without setting these two config ,then the API will throw exception.

@BoYiZhang
Copy link
Copy Markdown
Contributor Author

@BoYiZhang Why is the default value of connecTimeout & socketTimeout set through front-end?
I think this is not a good solution, it's better set in backend.
Let's say, somebody create the dag through the Restful API without setting these two config ,then the API will throw exception.

Use (APACHE httpclient jar) to process HTTP requests

Default timeout: 60000ms

The front-end setting is mainly for display. If you do not need to set the timeout, the parameters are hidden

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@davidzollo
Copy link
Copy Markdown
Contributor

@BoYiZhang Why is the default value of connecTimeout & socketTimeout set through front-end?
I think this is not a good solution, it's better set in backend.
Let's say, somebody create the dag through the Restful API without setting these two config ,then the API will throw exception.

the related issue: #2882

@davidzollo davidzollo merged commit f56ae9e into apache:dev Jun 12, 2020
@davidzollo davidzollo added the enhancement New feature or request label Jun 12, 2020
@zhuangchong zhuangchong added this to the 1.3.7-release milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QUESTION] http task 60s timeout(请问http类型的task60秒超时怎么配置)

5 participants