Compatible with flink1.10 or newer#2952
Merged
davidzollo merged 4 commits intoapache:devfrom Jun 12, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2952 +/- ##
============================================
- Coverage 38.14% 37.99% -0.15%
+ Complexity 2620 2613 -7
============================================
Files 436 436
Lines 20079 20084 +5
Branches 2443 2444 +1
============================================
- Hits 7659 7631 -28
- Misses 11711 11742 +31
- Partials 709 711 +2
Continue to review full report at Codecov.
|
Contributor
|
front end +1 |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
from flink1.10 version,flink removed "-yn" param，when config flink dag on ui,it would make error when Woker execute the flink dag script,I changed the ui code and user can choose flink version,which is <1.10 or >=1.10,when user choose >=1.10, it would remove "-yn" param in Worker
Brief change log
Verify this pull request
This change added tests and can be verified as follows: