Skip to content

add alert manage testCase and optimize test case execution order  #2941

Merged
lgcareer merged 29 commits intoapache:devfrom
xingchun-chen:dev
Jun 10, 2020
Merged

add alert manage testCase and optimize test case execution order  #2941
lgcareer merged 29 commits intoapache:devfrom
xingchun-chen:dev

Conversation

@xingchun-chen
Copy link
Copy Markdown
Contributor

Tips

What is the purpose of the pull request

(For example: This pull request adds checkstyle plugin.)

Brief change log

(for example:)

  • Add maven-checkstyle-plugin to root pom.xml

Verify this pull request

(Please pick either of the following options)

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added dolphinscheduler-dao tests for end-to-end.
  • Added CronUtilsTest to verify the change.
  • Manually verified the change by testing locally.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2941 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2941      +/-   ##
============================================
- Coverage     37.21%   37.17%   -0.04%     
+ Complexity     2560     2558       -2     
============================================
  Files           435      435              
  Lines         20020    20020              
  Branches       2426     2426              
============================================
- Hits           7451     7443       -8     
- Misses        11904    11909       +5     
- Partials        665      668       +3     
Impacted Files Coverage Δ Complexity Δ
...he/dolphinscheduler/common/thread/ThreadUtils.java 71.42% <0.00%> (-6.35%) 14.00% <0.00%> (ø%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.07% <0.00%> (-2.88%) 9.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21259d...26787fb. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Copy link
Copy Markdown
Contributor

@lgcareer lgcareer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lgcareer lgcareer merged commit 2749c7e into apache:dev Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants