Skip to content

Using Jackson instead of Fastjson#2850

Merged
davidzollo merged 3 commits intoapache:devfrom
hgaol:json
May 31, 2020
Merged

Using Jackson instead of Fastjson#2850
davidzollo merged 3 commits intoapache:devfrom
hgaol:json

Conversation

@hgaol
Copy link
Copy Markdown
Member

@hgaol hgaol commented May 31, 2020

Brief change log

  • Updated JSONUtils, deprecated Fastjson and use jackson
  • Added some tests

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 31, 2020 •
edited
Loading

Codecov Report

Merging #2850 into dev will increase coverage by 0.05%.
The diff coverage is 55.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2850      +/-   ##
============================================
+ Coverage     37.05%   37.10%   +0.05%     
- Complexity     2548     2553       +5     
============================================
  Files           434      435       +1     
  Lines         20015    20020       +5     
  Branches       2426     2426              
============================================
+ Hits           7416     7429      +13     
+ Misses        11929    11925       -4     
+ Partials        670      666       -4
Impacted Files Coverage Δ Complexity Δ
...che/dolphinscheduler/common/utils/StreamUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eduler/api/utils/exportprocess/DependentParam.java 20.58% <13.33%> (-52.95%) 4.00 <2.00> (-5.00)
...cheduler/api/service/ProcessDefinitionService.java 60.86% <54.95%> (-0.04%) 75.00 <4.00> (ø)
...pache/dolphinscheduler/common/utils/JSONUtils.java 66.10% <65.51%> (+8.47%) 16.00 <16.00> (+2.00)
...nscheduler/api/service/ProcessInstanceService.java 76.40% <100.00%> (-1.77%) 33.00 <0.00> (ø)
...duler/api/utils/exportprocess/DataSourceParam.java 70.58% <100.00%> (ø) 4.00 <2.00> (ø)
.../dolphinscheduler/common/utils/ParameterUtils.java 40.00% <100.00%> (ø) 13.00 <0.00> (ø)
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 9.00% <0.00%> (-1.00%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ab27a...889d8e9. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 31, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 5 Code Smells

53.3% 53.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@davidzollo davidzollo merged commit 8f8ddae into apache:dev May 31, 2020
davidzollo
davidzollo reviewed May 31, 2020
View reviewed changes
...uler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java
Map<String, Object> result = new HashMap<>(5);
String processMetaJson = FileUtils.file2String(file);
List<ProcessMeta> processMetaList = JSON.parseArray(processMetaJson,ProcessMeta.class);
List<ProcessMeta> processMetaList = JSON.parseArray(processMetaJson, ProcessMeta.class);
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this JSON come from fastjson

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this JSON come from fastjson

the import about fastjson line could be deleted

Copy link
Copy Markdown
Member Author

@hgaol hgaol May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I didn't fix all this kind of issues at this time. I'll do it next week. :)

@hgaol hgaol deleted the json branch May 31, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hgaol @codecov-commenter @davidzollo