Skip to content

Return ProcessDefinition ID, Scheduler ID when call the corresponding creation APIS#2849

Merged
davidzollo merged 2 commits intoapache:devfrom
GabrielWithTina:dev
May 30, 2020
Merged

Return ProcessDefinition ID, Scheduler ID when call the corresponding creation APIS#2849
davidzollo merged 2 commits intoapache:devfrom
GabrielWithTina:dev

Conversation

@GabrielWithTina
Copy link
Copy Markdown
Contributor

@GabrielWithTina GabrielWithTina commented May 30, 2020

What is the purpose of the pull request

*Return ProcessDefinition ID when call ProcessController.createProject.
*Return Scheduler ID when call SchedulerController.createScheduler.

Client system need the created object ID to bind the relationship between client system and Dolphinscheduler system.

Brief change log

*changed source files:
-dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java
-dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/SchedulerService.java

Verify this pull request

  • Manually verified the change by testing locally.

@GabrielWithTina
Merge remote-tracking branch 'upstream/dev' into HEAD
46c0648
@GabrielWithTina
Return ProcessDefinition ID when call ProcessController.createProject.
afca985 
Return Scheduler ID when call SchedulerController.createScheduler.

client need the created object ID to bind the relationship between client system and Dolphinscheduler system.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 30, 2020

Codecov Report

Merging #2849 into dev will decrease coverage by 0.12%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2849      +/-   ##
============================================
- Coverage     37.22%   37.10%   -0.13%     
+ Complexity     2557     2551       -6     
============================================
  Files           434      434              
  Lines         19992    19994       +2     
  Branches       2425     2425              
============================================
- Hits           7443     7418      -25     
- Misses        11880    11908      +28     
+ Partials        669      668       -1
Impacted Files Coverage Δ Complexity Δ
...dolphinscheduler/api/service/SchedulerService.java 2.52% <0.00%> (-0.02%) 3.00 <0.00> (ø)
...cheduler/api/service/ProcessDefinitionService.java 60.90% <100.00%> (+0.06%) 75.00 <0.00> (ø)
.../server/worker/processor/TaskExecuteProcessor.java 10.16% <0.00%> (-27.12%) 1.00% <0.00%> (-2.00%)
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 9.00% <0.00%> (-1.00%)
...nscheduler/server/entity/TaskExecutionContext.java 81.18% <0.00%> (-5.95%) 57.00% <0.00%> (-3.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 71.42% <0.00%> (-3.18%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c15345...afca985. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

davidzollo
davidzollo approved these changes May 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
it is your first PR, please add relevant unit test next time when you submit next PR

@davidzollo davidzollo merged commit d00627f into apache:dev May 30, 2020
@davidzollo davidzollo added the enhancement New feature or request label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GabrielWithTina @codecov-commenter @davidzollo