Skip to content

add job history to judge application status/2625#2848

Merged
davidzollo merged 5 commits intoapache:devfrom
itbasketplayer:dev
May 30, 2020
Merged

add job history to judge application status/2625#2848
davidzollo merged 5 commits intoapache:devfrom
itbasketplayer:dev

Conversation

@itbasketplayer
Copy link
Copy Markdown
Contributor

@itbasketplayer itbasketplayer commented May 30, 2020 •
edited
Loading

What is the purpose of the pull request

add job history status url to judge application status, when application number threshold is reached(default 10000,maybe it was set to 1000).
you can see issue #2625

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 30, 2020 •
edited
Loading

Codecov Report

Merging #2848 into dev will decrease coverage by 0.13%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2848      +/-   ##
============================================
- Coverage     37.25%   37.11%   -0.14%     
+ Complexity     2559     2552       -7     
============================================
  Files           434      434              
  Lines         19994    20006      +12     
  Branches       2425     2426       +1     
============================================
- Hits           7448     7426      -22     
- Misses        11880    11911      +31     
- Partials        666      669       +3
Impacted Files Coverage Δ Complexity Δ
.../org/apache/dolphinscheduler/common/Constants.java 83.33% <ø> (ø) 1.00 <0.00> (ø)
...che/dolphinscheduler/common/utils/HadoopUtils.java 34.67% <45.45%> (+2.05%) 21.00 <1.00> (+1.00)
.../server/worker/processor/TaskExecuteProcessor.java 10.16% <0.00%> (-27.12%) 1.00% <0.00%> (-2.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 71.42% <0.00%> (-6.35%) 14.00% <0.00%> (-1.00%)
...nscheduler/server/entity/TaskExecutionContext.java 81.18% <0.00%> (-5.95%) 57.00% <0.00%> (-3.00%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.07% <0.00%> (-2.88%) 9.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d00627f...b74b7d6. Read the comment docs.

@itbasketplayer
Copy link
Copy Markdown
Contributor Author

itbasketplayer commented May 30, 2020

image
this is not my change file :)

@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented May 30, 2020

could you submit this PR to dev-1.3.0, we will fix bug on the dev-1.3.0 first

when published 1.3.0, will have more energy for reviewing the PR on the dev

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

73.3% 73.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

davidzollo
davidzollo approved these changes May 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 1513aae into apache:dev May 30, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented May 30, 2020

could you submit a same PR to dev-1.3.0 which is used for publishing 1.3.0 version

@itbasketplayer
Copy link
Copy Markdown
Contributor Author

itbasketplayer commented May 30, 2020

ok, but i can't pull/push with github at home because of network. I will finish it next Monday.

@chengshiwen chengshiwen mentioned this pull request Dec 19, 2020
Closed
@chengshiwen chengshiwen mentioned this pull request Apr 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itbasketplayer @codecov-commenter @davidzollo