Skip to content

fix: Improve the security of datasource management#2844

Merged
davidzollo merged 2 commits intoapache:devfrom
ChunMengLu:dev
May 30, 2020
Merged

fix: Improve the security of datasource management#2844
davidzollo merged 2 commits intoapache:devfrom
ChunMengLu:dev

Conversation

@ChunMengLu
Copy link
Copy Markdown
Contributor

@ChunMengLu ChunMengLu commented May 29, 2020

What is the purpose of the pull request

Improve the security of datasource management

Brief change log

Closes #2638 Improve the security of datasource management

Verify this pull request

  1. Datasource info page not exposed password.
  2. Update datasource no password parameter，use old password。

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 30, 2020

Codecov Report

Merging #2844 into dev will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2844      +/-   ##
============================================
- Coverage     37.15%   37.10%   -0.05%     
+ Complexity     2551     2549       -2     
============================================
  Files           434      434              
  Lines         19986    19992       +6     
  Branches       2424     2425       +1     
============================================
- Hits           7425     7419       -6     
- Misses        11892    11903      +11     
- Partials        669      670       +1
Impacted Files Coverage Δ Complexity Δ
...olphinscheduler/api/service/DataSourceService.java 2.22% <0.00%> (-0.05%) 3.00 <0.00> (ø)
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 9.00% <0.00%> (-1.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 68.25% <0.00%> (-6.35%) 13.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbb8ff4...146874d. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

davidzollo
davidzollo approved these changes May 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented May 30, 2020

@xingchun-chen，please test this feature when you are free

@davidzollo davidzollo closed this May 30, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented May 30, 2020

sorry， Closed by mistake

@davidzollo davidzollo reopened this May 30, 2020
@davidzollo davidzollo merged commit 1c15345 into apache:dev May 30, 2020
@davidzollo davidzollo added the enhancement New feature or request label May 30, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented May 30, 2020

good job
It's your first contribution, looking forward for your deep participation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the security of datasource management

3 participants

@ChunMengLu @codecov-commenter @davidzollo