Skip to content

fix return value of created project#2804

Merged
davidzollo merged 2 commits intoapache:devfrom
white-infinity:dev
May 30, 2020
Merged

fix return value of created project#2804
davidzollo merged 2 commits intoapache:devfrom
white-infinity:dev

Conversation

@white-infinity
Copy link
Copy Markdown
Contributor

@white-infinity white-infinity commented May 24, 2020 •
edited
Loading

What is the purpose of the pull request

fix /dolphinscheduler/projects/create doesn't return project ID when create successfuly #2619

Brief change log

fix /projects/create api and corresponding test case

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 24, 2020 •
edited
Loading

Codecov Report

Merging #2804 into dev will decrease coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2804      +/-   ##
============================================
- Coverage     37.32%   37.04%   -0.29%     
+ Complexity     2563     2546      -17     
============================================
  Files           434      434              
  Lines         19983    19986       +3     
  Branches       2424     2424              
============================================
- Hits           7459     7403      -56     
- Misses        11860    11919      +59     
  Partials        664      664
Impacted Files Coverage Δ Complexity Δ
...e/dolphinscheduler/api/service/ProjectService.java 86.70% <100.00%> (+0.25%) 39.00 <0.00> (ø)
...duler/server/entity/DataxTaskExecutionContext.java 35.00% <0.00%> (-60.00%) 7.00% <0.00%> (-6.00%)
.../server/worker/processor/TaskExecuteProcessor.java 10.16% <0.00%> (-27.12%) 1.00% <0.00%> (-2.00%)
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 9.00% <0.00%> (-1.00%)
...nscheduler/server/entity/TaskExecutionContext.java 81.18% <0.00%> (-5.95%) 57.00% <0.00%> (-3.00%)
...org/apache/dolphinscheduler/remote/utils/Host.java 25.71% <0.00%> (-5.72%) 5.00% <0.00%> (-1.00%)
...ver/master/consumer/TaskPriorityQueueConsumer.java 54.41% <0.00%> (-5.15%) 16.00% <0.00%> (ø%)
...ler/server/master/runner/MasterTaskExecThread.java 8.98% <0.00%> (-4.50%) 2.00% <0.00%> (-1.00%)
...pache/dolphinscheduler/alert/utils/ExcelUtils.java 78.94% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...cheduler/server/registry/ZookeeperNodeManager.java 74.72% <0.00%> (-3.30%) 6.00% <0.00%> (-1.00%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e89f543...c490518. Read the comment docs.

davidzollo
davidzollo approved these changes May 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@davidzollo davidzollo merged commit fbb8ff4 into apache:dev May 30, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented May 30, 2020

good job

this is your first contribution，looking forward for your deep participation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] /dolphinscheduler/projects/create doesn't return project ID when create successfuly

3 participants

@white-infinity @codecov-commenter @davidzollo