Skip to content

update e2e chrome version#2778

Merged
lenboo merged 27 commits intoapache:devfrom
xingchun-chen:dev
May 21, 2020
Merged

update e2e chrome version#2778
lenboo merged 27 commits intoapache:devfrom
xingchun-chen:dev

Conversation

@xingchun-chen
Copy link
Copy Markdown
Contributor

Tips

What is the purpose of the pull request

(For example: This pull request adds checkstyle plugin.)

Brief change log

(for example:)

  • Add maven-checkstyle-plugin to root pom.xml

Verify this pull request

(Please pick either of the following options)

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added dolphinscheduler-dao tests for end-to-end.
  • Added CronUtilsTest to verify the change.
  • Manually verified the change by testing locally.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2778 into dev will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2778      +/-   ##
============================================
- Coverage     37.33%   37.11%   -0.23%     
+ Complexity     2564     2549      -15     
============================================
  Files           434      434              
  Lines         19983    19983              
  Branches       2424     2424              
============================================
- Hits           7460     7416      -44     
- Misses        11859    11897      +38     
- Partials        664      670       +6     
Impacted Files Coverage Δ Complexity Δ
...duler/server/entity/DataxTaskExecutionContext.java 35.00% <0.00%> (-60.00%) 7.00% <0.00%> (-6.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 68.25% <0.00%> (-9.53%) 13.00% <0.00%> (-2.00%)
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 9.00% <0.00%> (-1.00%)
...ver/master/consumer/TaskPriorityQueueConsumer.java 54.41% <0.00%> (-5.15%) 16.00% <0.00%> (ø%)
...ler/server/master/runner/MasterTaskExecThread.java 8.98% <0.00%> (-4.50%) 2.00% <0.00%> (-1.00%)
...pache/dolphinscheduler/alert/utils/ExcelUtils.java 78.94% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...cheduler/server/registry/ZookeeperNodeManager.java 74.72% <0.00%> (-3.30%) 6.00% <0.00%> (-1.00%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.07% <0.00%> (-2.88%) 9.00% <0.00%> (-2.00%)
...master/dispatch/executor/NettyExecutorManager.java 83.92% <0.00%> (-1.79%) 10.00% <0.00%> (ø%)
...pache/dolphinscheduler/common/utils/FileUtils.java 28.03% <0.00%> (-0.94%) 9.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a78c11...9f2fbc7. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit 714ad5d into apache:dev May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants