Skip to content

simply doExecute using RetryerUtils.retryCall#2761

Merged
davidzollo merged 2 commits intoapache:devfrom
gabry-lab:simplyDoExecuteWitRetryer
Jul 13, 2020
Merged

simply doExecute using RetryerUtils.retryCall#2761
davidzollo merged 2 commits intoapache:devfrom
gabry-lab:simplyDoExecuteWitRetryer

Conversation

@gabry-lab
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab commented May 19, 2020

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2020 •
edited
Loading

Codecov Report

Merging #2761 into dev will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2761      +/-   ##
============================================
- Coverage     39.29%   39.25%   -0.05%     
+ Complexity     2687     2685       -2     
============================================
  Files           435      435              
  Lines         20116    20109       -7     
  Branches       2453     2451       -2     
============================================
- Hits           7905     7893      -12     
- Misses        11473    11482       +9     
+ Partials        738      734       -4
Impacted Files Coverage Δ Complexity Δ
...master/dispatch/executor/NettyExecutorManager.java 81.63% <100.00%> (-2.30%) 8.00 <1.00> (-2.00)
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) 0.00% <0.00%> (-3.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 71.42% <0.00%> (-3.18%) 14.00% <0.00%> (ø%)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) 25.00% <0.00%> (ø%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.95% <0.00%> (+2.87%) 11.00% <0.00%> (+2.00%)
...r/master/dispatch/exceptions/ExecuteException.java 40.00% <0.00%> (+20.00%) 2.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c4c58...25b001f. Read the comment docs.

@gabry-lab gabry-lab requested review from Technoboy- and wen-hemin May 20, 2020 03:35
@gabry-lab
Copy link
Copy Markdown
Member Author

gabry-lab commented May 22, 2020

hi, @qiaozhanwei could you help to review this PR ?

@gabry-lab gabry-lab removed the request for review from Technoboy- May 24, 2020 03:10
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

davidzollo
davidzollo approved these changes Jul 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@davidzollo davidzollo dismissed wen-hemin’s stale review July 13, 2020 06:37

sleep 1000 also will be OK

@davidzollo davidzollo added the enhancement New feature or request label Jul 13, 2020
@davidzollo davidzollo merged commit 75259dc into apache:dev Jul 13, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented Jul 13, 2020

@lgcareer , I think DolphinScheduler's license file should add https://github.com/rholder/guava-retrying

@gabry-lab gabry-lab deleted the simplyDoExecuteWitRetryer branch July 13, 2020 08:12
@gabry-lab
Copy link
Copy Markdown
Member Author

gabry-lab commented Jul 13, 2020

The guava-retrying module is released under version 2.0 of the Apache License.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

@wen-hemin wen-hemin wen-hemin left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gabry-lab @codecov-commenter @davidzollo @wen-hemin