Skip to content

fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…#2752

Closed
1445103710 wants to merge 5 commits intoapache:devfrom
1445103710:dev
Closed

fix [BUG] TaskExecutionContextCacheManagerImpl Do not execute removeB…#2752
1445103710 wants to merge 5 commits intoapache:devfrom
1445103710:dev

Conversation

@1445103710
Copy link
Copy Markdown
Contributor

…yTaskInstanceId #2745

Tips

What is the purpose of the pull request

(For example: This pull request adds checkstyle plugin.)

Brief change log

(for example:)

  • Add maven-checkstyle-plugin to root pom.xml

Verify this pull request

(Please pick either of the following options)

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added dolphinscheduler-dao tests for end-to-end.
  • Added CronUtilsTest to verify the change.
  • Manually verified the change by testing locally.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2020

Codecov Report

Merging #2752 into dev will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2752      +/-   ##
============================================
- Coverage     37.14%   37.01%   -0.14%     
+ Complexity     2555     2545      -10     
============================================
  Files           434      434              
  Lines         20006    20009       +3     
  Branches       2426     2426              
============================================
- Hits           7432     7406      -26     
- Misses        11907    11933      +26     
- Partials        667      670       +3     
Impacted Files Coverage Δ Complexity Δ
...ler/server/worker/processor/TaskKillProcessor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...eduler/server/worker/runner/TaskExecuteThread.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...duler/server/entity/DataxTaskExecutionContext.java 35.00% <0.00%> (-60.00%) 7.00% <0.00%> (-6.00%)
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 9.00% <0.00%> (-1.00%)
...ver/master/consumer/TaskPriorityQueueConsumer.java 54.41% <0.00%> (-4.42%) 16.00% <0.00%> (ø%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 68.25% <0.00%> (-3.18%) 13.00% <0.00%> (-1.00%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.07% <0.00%> (-2.88%) 9.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1513aae...4c09218. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@gabry-lab
Copy link
Copy Markdown
Member

another PR merged #2754 , I will close this one

@gabry-lab gabry-lab closed this Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants