Skip to content

Fix compile issue#2718

Merged
gabry-lab merged 9 commits intoapache:devfrom
oceanos:dev
Jun 14, 2020
Merged

Fix compile issue#2718
gabry-lab merged 9 commits intoapache:devfrom
oceanos:dev

Conversation

@oceanos
Copy link
Copy Markdown
Contributor

@oceanos oceanos commented May 14, 2020

What is the purpose of the pull request

fix compile error #2715

Brief change log

  • UsersServiceTest.java

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 14, 2020 •
edited
Loading

Codecov Report

Merging #2718 into dev will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2718      +/-   ##
============================================
- Coverage     37.12%   37.10%   -0.03%     
+ Complexity     2545     2543       -2     
============================================
  Files           433      433              
  Lines         19958    19958              
  Branches       2423     2423              
============================================
- Hits           7409     7405       -4     
- Misses        11881    11884       +3     
- Partials        668      669       +1
Impacted Files Coverage Δ Complexity Δ
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 9.00% <0.00%> (-1.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 68.25% <0.00%> (-3.18%) 13.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ee7d1...f13bf5c. Read the comment docs.

davidzollo
davidzollo approved these changes May 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

gabry-lab
gabry-lab approved these changes May 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 29, 2020 •
edited
Loading

Codecov Report

Merging #2718 into dev will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2718      +/-   ##
============================================
- Coverage     39.30%   39.24%   -0.07%     
+ Complexity     2687     2684       -3     
============================================
  Files           435      435              
  Lines         20116    20116              
  Branches       2453     2453              
============================================
- Hits           7907     7894      -13     
- Misses        11472    11486      +14     
+ Partials        737      736       -1
Impacted Files Coverage Δ Complexity Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) 0.00% <0.00%> (-3.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 71.42% <0.00%> (-6.35%) 14.00% <0.00%> (ø%)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) 25.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c4c58...9ee17fd. Read the comment docs.

@gabry-lab
Copy link
Copy Markdown
Member

gabry-lab commented Jun 13, 2020

This is just compiling warn ,not errors . unnecessary import

@gabry-lab gabry-lab mentioned this pull request Jun 13, 2020
Closed
@gabry-lab gabry-lab changed the title Fix compile error Fix compile issue Jun 13, 2020
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@gabry-lab gabry-lab merged commit 9fd7289 into apache:dev Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

+1 more reviewer

@gabry-lab gabry-lab gabry-lab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oceanos @codecov-io @codecov-commenter @gabry-lab @davidzollo