Skip to content

Deprecated method changes#2706

Merged
davidzollo merged 4 commits intoapache:devfrom
CalvinKirs:small_modify
May 14, 2020
Merged

Deprecated method changes#2706
davidzollo merged 4 commits intoapache:devfrom
CalvinKirs:small_modify

Conversation

@CalvinKirs
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs commented May 13, 2020

Tips

What is the purpose of the pull request

Deprecated method changes

Brief change log

(for example:)

  • Add maven-checkstyle-plugin to root pom.xml

Verify this pull request

test

This change added tests and can be verified as follows:

test

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 14, 2020 •
edited
Loading

Codecov Report

Merging #2706 into dev will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2706      +/-   ##
============================================
+ Coverage     37.12%   37.17%   +0.05%     
- Complexity     2549     2553       +4     
============================================
  Files           434      434              
  Lines         19975    19977       +2     
  Branches       2423     2423              
============================================
+ Hits           7415     7427      +12     
+ Misses        11894    11882      -12     
- Partials        666      668       +2
Impacted Files Coverage Δ Complexity Δ
...dolphinscheduler/service/zk/ZookeeperOperator.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...he/dolphinscheduler/common/thread/ThreadUtils.java 71.42% <0.00%> (-3.18%) 14.00% <0.00%> (ø%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.07% <0.00%> (-2.88%) 9.00% <0.00%> (-2.00%)
...ver/master/consumer/TaskPriorityQueueConsumer.java 58.82% <0.00%> (+4.41%) 16.00% <0.00%> (ø%)
...duler/server/entity/DataxTaskExecutionContext.java 95.00% <0.00%> (+60.00%) 13.00% <0.00%> (+6.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28a697...af392cf. Read the comment docs.

davidzollo
davidzollo approved these changes May 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented May 14, 2020

considering that it's your first contribution, I think we can get deep communiction, you can contact me through mail or add wechat(510570367), when mail or added, please tell me who you are, I think I can help to familiar with the DolphinScheduler if you meet with problems.

@davidzollo davidzollo merged commit 0226f9f into apache:dev May 14, 2020
@davidzollo davidzollo added the enhancement New feature or request label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CalvinKirs @codecov-io @davidzollo