Skip to content

change variable name ,make it easy to understand#2647

Merged
davidzollo merged 3 commits intoapache:devfrom
gabry-lab:alertPlugin
May 14, 2020
Merged

change variable name ,make it easy to understand#2647
davidzollo merged 3 commits intoapache:devfrom
gabry-lab:alertPlugin

Conversation

@gabry-lab
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2647 into dev will increase coverage by 0.08%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2647      +/-   ##
============================================
+ Coverage     36.21%   36.29%   +0.08%     
- Complexity     2476     2480       +4     
============================================
  Files           431      431              
  Lines         19893    19893              
  Branches       2421     2421              
============================================
+ Hits           7204     7220      +16     
+ Misses        12048    12029      -19     
- Partials        641      644       +3     
Impacted Files Coverage Δ Complexity Δ
...che/dolphinscheduler/alert/runner/AlertSender.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...apache/dolphinscheduler/alert/utils/Constants.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...olphinscheduler/alert/plugin/EmailAlertPlugin.java 54.00% <100.00%> (ø) 5.00 <1.00> (ø)
...phinscheduler/common/plugin/FilePluginManager.java 41.46% <100.00%> (ø) 6.00 <1.00> (ø)
...he/dolphinscheduler/common/thread/ThreadUtils.java 68.25% <0.00%> (-9.53%) 13.00% <0.00%> (-1.00%)
...nscheduler/server/entity/TaskExecutionContext.java 79.20% <0.00%> (+5.94%) 56.00% <0.00%> (+3.00%)
.../server/worker/processor/TaskExecuteProcessor.java 36.66% <0.00%> (+26.66%) 3.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daea87a...191a114. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@davidzollo davidzollo merged commit 1771aa5 into apache:dev May 14, 2020
@gabry-lab gabry-lab deleted the alertPlugin branch May 15, 2020 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants