Skip to content

unique check before import ProcessDefinitions#2617

Merged
xingchun-chen merged 5 commits intoapache:devfrom
simon824:dev
May 7, 2020
Merged

unique check before import ProcessDefinitions#2617
xingchun-chen merged 5 commits intoapache:devfrom
simon824:dev

Conversation

@simon824
Copy link
Copy Markdown
Member

@simon824 simon824 commented May 7, 2020

fix #2559

  1. unique check before import ProcessDefinitions
  2. add unique key on name and project_id

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 7, 2020

Codecov Report

Merging #2617 into dev will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2617      +/-   ##
============================================
+ Coverage     36.47%   36.50%   +0.02%     
- Complexity     2492     2494       +2     
============================================
  Files           431      431              
  Lines         19872    19878       +6     
  Branches       2423     2424       +1     
============================================
+ Hits           7249     7256       +7     
  Misses        11970    11970              
+ Partials        653      652       -1     
Impacted Files Coverage Δ Complexity Δ
...cheduler/api/service/ProcessDefinitionService.java 70.35% <50.00%> (-0.20%) 92.00 <0.00> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.95% <0.00%> (+2.87%) 11.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697ea0f...ec2509f. Read the comment docs.

Copy link
Copy Markdown
Contributor

@xingchun-chen xingchun-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@xingchun-chen xingchun-chen merged commit 6127f3a into apache:dev May 7, 2020
@xingchun-chen
Copy link
Copy Markdown
Contributor

@simon824 hello, change the database fields need to send an email discussion, change the database need to change mysql.sql, postgres.sql and myql 、postgresql update script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]unique processdefinition name in the same project

3 participants