Skip to content

Work example page list supports scrolling #2554#2586

Merged
xingchun-chen merged 2 commits intoapache:devfrom
break60:dev
Apr 30, 2020
Merged

Work example page list supports scrolling #2554#2586
xingchun-chen merged 2 commits intoapache:devfrom
break60:dev

Conversation

@break60
Copy link
Copy Markdown
Contributor

@break60 break60 commented Apr 30, 2020

Because there are not many fields in the job definition page, it is currently fixed, and the workflow instance page has scrolling

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2586 into dev will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2586      +/-   ##
============================================
- Coverage     36.19%   36.06%   -0.13%     
+ Complexity     2428     2421       -7     
============================================
  Files           424      424              
  Lines         19624    19624              
  Branches       2395     2395              
============================================
- Hits           7102     7078      -24     
- Misses        11893    11917      +24     
  Partials        629      629              
Impacted Files Coverage Δ Complexity Δ
.../server/worker/processor/TaskExecuteProcessor.java 10.71% <0.00%> (-28.58%) 1.00% <0.00%> (-2.00%)
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 9.00% <0.00%> (-1.00%)
...nscheduler/server/entity/TaskExecutionContext.java 73.26% <0.00%> (-5.95%) 53.00% <0.00%> (-3.00%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.07% <0.00%> (-2.88%) 9.00% <0.00%> (-2.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 77.77% <0.00%> (+6.34%) 15.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94748a...9197a68. Read the comment docs.

Copy link
Copy Markdown
Contributor

@xingchun-chen xingchun-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xingchun-chen xingchun-chen merged commit d629d38 into apache:dev Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants