Skip to content

fix The create user is always loading when the queue does not select any value#2558

Merged
xingchun-chen merged 9 commits intoapache:devfrom
samz406:dev
May 7, 2020
Merged

fix The create user is always loading when the queue does not select any value#2558
xingchun-chen merged 9 commits intoapache:devfrom
samz406:dev

Conversation

@samz406
Copy link
Copy Markdown
Contributor

@samz406 samz406 commented Apr 28, 2020

fix issue #2545

The create user is always loading when the queue does not select any value

@qiaozhanwei
Copy link
Copy Markdown
Contributor

@break60

@break60
Copy link
Copy Markdown
Contributor

break60 commented Apr 30, 2020

frontend +1

Copy link
Copy Markdown
Contributor Author

@samz406 samz406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@samz406 samz406 requested a review from xingchun-chen May 6, 2020 03:56
@samz406
Copy link
Copy Markdown
Contributor Author

samz406 commented May 7, 2020

@xingchun-chen please review

@xingchun-chen
Copy link
Copy Markdown
Contributor

I will test it
 

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2558 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2558      +/-   ##
============================================
+ Coverage     36.44%   36.47%   +0.03%     
- Complexity     2490     2492       +2     
============================================
  Files           431      431              
  Lines         19872    19872              
  Branches       2423     2423              
============================================
+ Hits           7243     7249       +6     
+ Misses        11974    11970       -4     
+ Partials        655      653       -2     
Impacted Files Coverage Δ Complexity Δ
...he/dolphinscheduler/common/thread/ThreadUtils.java 77.77% <0.00%> (+9.52%) 15.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 632b2b5...b7e3dd4. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@xingchun-chen xingchun-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@xingchun-chen xingchun-chen merged commit 697ea0f into apache:dev May 7, 2020
@xingchun-chen
Copy link
Copy Markdown
Contributor

When creating a user, the queue value is not passed in the front end, and the queue in the database is also empty, but the user management is queried, and the queue is returned by the back end
 

image
image

image

@samz406
Copy link
Copy Markdown
Contributor Author

samz406 commented May 7, 2020

i will check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants