Skip to content

fix ui i18n issue#2503

Merged
xingchun-chen merged 20 commits intoapache:devfrom
oceanos:dev
Apr 24, 2020
Merged

fix ui i18n issue#2503
xingchun-chen merged 20 commits intoapache:devfrom
oceanos:dev

Conversation

@oceanos
Copy link
Copy Markdown
Contributor

@oceanos oceanos commented Apr 23, 2020

What is the purpose of the pull request

fix ui i18n issue

Brief change log

showType in sql.vue

  • en_US.js
  • zh_CN.js
  • remove duplicate Modify User

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2503 into dev will increase coverage by 0.02%.
The diff coverage is 47.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2503      +/-   ##
============================================
+ Coverage     35.91%   35.93%   +0.02%     
- Complexity     2395     2400       +5     
============================================
  Files           423      424       +1     
  Lines         19540    19557      +17     
  Branches       2384     2385       +1     
============================================
+ Hits           7017     7028      +11     
- Misses        11899    11905       +6     
  Partials        624      624              
Impacted Files Coverage Δ Complexity Δ
.../dolphinscheduler/api/service/ExecutorService.java 32.14% <0.00%> (ø) 16.00 <0.00> (ø)
...dolphinscheduler/api/service/ResourcesService.java 56.78% <22.22%> (-0.41%) 66.00 <0.00> (+1.00) ⬇️
...phinscheduler/api/exceptions/ServiceException.java 69.23% <69.23%> (ø) 4.00 <4.00> (?)
...he/dolphinscheduler/common/thread/ThreadUtils.java 74.60% <0.00%> (+3.17%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aff45c...e4dad2a. Read the comment docs.

@davidzollo
Copy link
Copy Markdown
Contributor

@break60 please review this issue

@break60
Copy link
Copy Markdown
Contributor

break60 commented Apr 23, 2020

+1

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@xingchun-chen xingchun-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants