Skip to content

[fix #2442] It will give a error tip that resource not exist exwhen update resources. #2483

Merged
qiaozhanwei merged 10 commits intoapache:devfrom
lgcareer:dev-fix-updateResource
Apr 23, 2020
Merged

[fix #2442] It will give a error tip that resource not exist exwhen update resources. #2483
qiaozhanwei merged 10 commits intoapache:devfrom
lgcareer:dev-fix-updateResource

Conversation

@lgcareer
Copy link
Copy Markdown
Contributor

@lgcareer lgcareer commented Apr 21, 2020

What is the purpose of the pull request

*[fix #2442] It will give a tip that resource not exist exwhen update resources. *

Brief change log

update the update method of resource
remove unavailable code

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 21, 2020 •
edited
Loading

Codecov Report

Merging #2483 into dev will increase coverage by 0.13%.
The diff coverage is 47.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2483      +/-   ##
============================================
+ Coverage     35.91%   36.04%   +0.13%     
- Complexity     2395     2405      +10     
============================================
  Files           423      424       +1     
  Lines         19540    19557      +17     
  Branches       2384     2385       +1     
============================================
+ Hits           7017     7050      +33     
+ Misses        11899    11882      -17     
- Partials        624      625       +1
Impacted Files Coverage Δ Complexity Δ
.../dolphinscheduler/api/service/ExecutorService.java 32.14% <0.00%> (ø) 16.00 <0.00> (ø)
...dolphinscheduler/api/service/ResourcesService.java 56.78% <22.22%> (-0.41%) 66.00 <0.00> (+1.00) ⬇️
...phinscheduler/api/exceptions/ServiceException.java 69.23% <69.23%> (ø) 4.00 <4.00> (?)
...he/dolphinscheduler/common/thread/ThreadUtils.java 74.60% <0.00%> (+3.17%) 14.00% <0.00%> (ø%)
...nscheduler/server/entity/TaskExecutionContext.java 79.20% <0.00%> (+5.94%) 56.00% <0.00%> (+3.00%)
.../server/worker/processor/TaskExecuteProcessor.java 39.28% <0.00%> (+28.57%) 3.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5fdce4...d920cc7. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

53.6% 53.6% Coverage
0.0% 0.0% Duplication

@lgcareer lgcareer requested review from lenboo and qiaozhanwei April 23, 2020 06:08
qiaozhanwei
qiaozhanwei approved these changes Apr 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 44770a8 into apache:dev Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiaozhanwei qiaozhanwei qiaozhanwei approved these changes

@lenboo lenboo Awaiting requested review from lenboo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] update the directory of resource is error

3 participants

@lgcareer @codecov-io @qiaozhanwei