Fix some code specification issues#2482
Merged
davidzollo merged 12 commits intoapache:devfrom May 10, 2020
Merged
Conversation
* Pre-compile regular expressions to improve efficiency and solve concurrency problems
* Solve the nullpoint problem that Object.equals may bring
* Modify if else structure, add {} to improve code readability
Co-Authored-By: daili <daili@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Contributor
|
Coverage for new codes is required more than 33%, please add more UT. You can see more detail at: |
Codecov Report
@@ Coverage Diff @@
## dev #2482 +/- ##
============================================
- Coverage 37.09% 36.12% -0.97%
+ Complexity 2534 2470 -64
============================================
Files 431 431
Lines 19856 19879 +23
Branches 2419 2419
============================================
- Hits 7366 7182 -184
- Misses 11825 12053 +228
+ Partials 665 644 -21
Continue to review full report at Codecov.
|
re-run test process
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-compile regular expressions to improve efficiency and solve concurrency problems
Solve the nullpoint problem that Object.equals may bring
Modify if else structure, add {} to improve code readability
Co-Authored-By: daili daili@users.noreply.github.com
Tips
What is the purpose of the pull request
Pre-compile regular expressions to improve efficiency and solve concurrency problems
Solve the nullpoint problem that Object.equals may bring
Modify if else structure, add {} to improve code readability