Skip to content

Add query result set limit.#2459

Merged
qiaozhanwei merged 16 commits intoapache:devfrom
yh2388:optimize-3
Apr 27, 2020
Merged

Add query result set limit.#2459
qiaozhanwei merged 16 commits intoapache:devfrom
yh2388:optimize-3

Conversation

@yh2388
Copy link
Copy Markdown
Contributor

@yh2388 yh2388 commented Apr 19, 2020

Prevents users from querying large tables without limiting the size of the result set.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 19, 2020

Codecov Report

Merging #2459 into dev will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2459      +/-   ##
============================================
- Coverage     36.07%   35.93%   -0.15%     
+ Complexity     2412     2406       -6     
============================================
  Files           424      424              
  Lines         19587    19589       +2     
  Branches       2390     2390              
============================================
- Hits           7066     7039      -27     
- Misses        11896    11928      +32     
+ Partials        625      622       -3     
Impacted Files Coverage Δ Complexity Δ
...lphinscheduler/server/worker/task/sql/SqlTask.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../server/worker/processor/TaskExecuteProcessor.java 10.71% <0.00%> (-28.58%) 1.00% <0.00%> (-2.00%)
...nscheduler/server/entity/TaskExecutionContext.java 73.26% <0.00%> (-5.95%) 53.00% <0.00%> (-3.00%)
...he/dolphinscheduler/common/thread/ThreadUtils.java 74.60% <0.00%> (-3.18%) 14.00% <0.00%> (ø%)
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.07% <0.00%> (-2.16%) 9.00% <0.00%> (-1.00%)
...inscheduler/common/task/sqoop/SqoopParameters.java 80.00% <0.00%> (ø) 15.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13c08d...f988291. Read the comment docs.

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@qiaozhanwei qiaozhanwei merged commit c50ad12 into apache:dev Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants