Skip to content

fix: Gantt chart bug #2439#2440

Merged
xingchun-chen merged 5 commits intoapache:devfrom
wen-hemin:fixbug-#2439
Apr 17, 2020
Merged

fix: Gantt chart bug #2439#2440
xingchun-chen merged 5 commits intoapache:devfrom
wen-hemin:fixbug-#2439

Conversation

@wen-hemin
Copy link
Copy Markdown
Contributor

Please see #2439 for details.

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@break60
Copy link
Copy Markdown
Contributor

break60 commented Apr 17, 2020

Why do you want to change the name to taskNames, can you continue to use taskName?
image

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2440 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2440      +/-   ##
============================================
- Coverage     33.44%   33.43%   -0.02%     
  Complexity     2305     2305              
============================================
  Files           423      423              
  Lines         19860    19860              
  Branches       2375     2375              
============================================
- Hits           6643     6641       -2     
- Misses        12637    12638       +1     
- Partials        580      581       +1     
Impacted Files Coverage Δ Complexity Δ
...he/dolphinscheduler/common/thread/ThreadUtils.java 68.25% <0.00%> (-6.35%) 13.00% <0.00%> (-1.00%)
...scheduler/alert/template/AlertTemplateFactory.java 71.42% <0.00%> (+28.57%) 3.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a8b56...5ccd742. Read the comment docs.

@wen-hemin
Copy link
Copy Markdown
Contributor Author

Why do you want to change the name to taskNames, can you continue to use taskName?
image

Before is tasksName, I fix to taskNames. taskNames is a array.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
22.2% 22.2% Duplication

@break60
Copy link
Copy Markdown
Contributor

break60 commented Apr 17, 2020

Before is tasksName, I fix to taskNames. taskNames is a array.

+1

@xingchun-chen xingchun-chen merged commit c4f44a6 into apache:dev Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants