Skip to content

fix NPE when grant resource or save process definition#2434

Merged
davidzollo merged 2 commits intoapache:devfrom
lgcareer:dev-fix-grant-resource
Apr 15, 2020
Merged

fix NPE when grant resource or save process definition#2434
davidzollo merged 2 commits intoapache:devfrom
lgcareer:dev-fix-grant-resource

Conversation

@lgcareer
Copy link
Copy Markdown
Contributor

What is the purpose of the pull request

fix NPE when grant resource or save process definition

Brief change log

fix NPE when grant resource or save process definition
change worker_group from 255 to 64

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2434 into dev will decrease coverage by 0.02%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2434      +/-   ##
============================================
- Coverage     33.47%   33.44%   -0.03%     
+ Complexity     2307     2306       -1     
============================================
  Files           423      423              
  Lines         19868    19870       +2     
  Branches       2373     2375       +2     
============================================
- Hits           6650     6646       -4     
- Misses        12624    12632       +8     
+ Partials        594      592       -2     
Impacted Files Coverage Δ Complexity Δ
...cheduler/api/service/ProcessDefinitionService.java 71.23% <0.00%> (-0.46%) 82.00 <0.00> (ø)
...che/dolphinscheduler/api/service/UsersService.java 71.17% <85.71%> (-0.21%) 66.00 <0.00> (ø)
...he/dolphinscheduler/api/service/LoggerService.java 82.60% <0.00%> (-8.70%) 6.00% <0.00%> (-1.00%)
...ache/dolphinscheduler/dao/entity/ErrorCommand.java 33.33% <0.00%> (ø) 21.00% <0.00%> (ø%)
...inscheduler/common/task/sqoop/SqoopParameters.java 80.00% <0.00%> (ø) 15.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f218370...bf2fde2. Read the comment docs.

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@davidzollo davidzollo merged commit 8b4eb20 into apache:dev Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants