Skip to content

1，task status statistics and process status statistics bug fix (#2357) 2，worker group bug fix#2430

Merged
lgcareer merged 24 commits intoapache:devfrom
qiaozhanwei:dev
Apr 16, 2020
Merged

1，task status statistics and process status statistics bug fix (#2357) 2，worker group bug fix#2430
lgcareer merged 24 commits intoapache:devfrom
qiaozhanwei:dev

Conversation

@qiaozhanwei
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei commented Apr 15, 2020

1，task status statistics and process status statistics bug fix (#2357)
2，worker group bug fix

qiaozhanwei and others added 24 commits April 13, 2020 15:43
dispatch task fail will set task status failed
cf917e9
1，no worker condition , master will while ture wait for worker startup
1a27507 
2，worker response task status sync wait for result
@qiaozhanwei
Merge branch 'dev' into dev
95d58a2
1，no worker condition , master will while ture wait for worker startup
349dd18 
2，worker response task status sync wait for result
Merge remote-tracking branch 'origin/dev' into dev
facb043
1，no worker condition , master will while ture wait for worker startup
a7bbc5f 
2，worker response task status sync wait for result
1，no worker condition , master will while ture wait for worker startup
1d79562 
2，worker response task status sync wait for result
1，no worker condition , master will while ture wait for worker startup
1cd1ce6 
2，worker response task status sync wait for result
1，no worker condition , master will while ture wait for worker startup
0c6b0f2 
2，worker response task status sync wait for result
1，no worker condition , master will while ture wait for worker startup
33ec332 
2，worker response task status sync wait for result
1，no worker condition , master will while ture wait for worker startup
bd1003f 
2，worker response task status sync wait for result
Merge remote-tracking branch 'remotes/upstream/dev' into dev
a25f2e8
1，no worker condition , master will while ture wait for worker startup
f29f45e 
2，worker response task status sync wait for result
1，no worker condition , master will while ture wait for worker startup
f3eb306 
2，worker response task status sync wait for result
1，no worker condition , master will while ture wait for worker startup
bc84b83 
2，worker response task status sync wait for result
Merge remote-tracking branch 'remotes/upstream/dev' into dev
fc7e0e7
1，task status statistics and process status statistics bug fix (#2357)
7f1a562 
2，worker group bug fix
@qiaozhanwei
Merge branch 'dev' into dev
1e26193
@qiaozhanwei
Merge branch 'dev' into dev
e4807ac
Merge remote-tracking branch 'remotes/upstream/dev' into dev
88968c7
1，task status statistics and process status statistics bug fix (#2357)
a1dd6db 
2，worker group bug fix
Merge remote-tracking branch 'origin/dev' into dev
49c8c66
1，task status statistics and process status statistics bug fix (#2357)
3ad6519 
2，worker group bug fix
1，task status statistics and process status statistics bug fix (#2357)
a9c8639 
2，worker group bug fix
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 16, 2020 •
edited
Loading

Codecov Report

Merging #2430 into dev will decrease coverage by 0.04%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2430      +/-   ##
============================================
- Coverage     33.48%   33.43%   -0.05%     
+ Complexity     2309     2305       -4     
============================================
  Files           423      423              
  Lines         19868    19864       -4     
  Branches       2373     2375       +2     
============================================
- Hits           6652     6641      -11     
- Misses        12623    12642      +19     
+ Partials        593      581      -12
Impacted Files Coverage Δ Complexity Δ
...cheduler/api/service/ProcessDefinitionService.java 71.23% <0.00%> (-0.46%) 82.00 <0.00> (ø)
...he/dolphinscheduler/common/thread/ThreadUtils.java 68.25% <0.00%> (-3.42%) 13.00 <0.00> (ø)
...rg/apache/dolphinscheduler/dao/entity/Command.java 43.63% <ø> (ø) 29.00 <0.00> (ø)
...ver/master/consumer/TaskPriorityQueueConsumer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...uler/server/master/processor/TaskAckProcessor.java 72.00% <0.00%> (+2.76%) 2.00 <0.00> (ø)
...r/server/worker/processor/TaskCallbackService.java 69.76% <0.00%> (+3.10%) 10.00 <0.00> (ø)
...phinscheduler/api/service/DataAnalysisService.java 59.75% <50.00%> (-0.96%) 14.00 <0.00> (-2.00)
...che/dolphinscheduler/api/service/UsersService.java 71.17% <85.71%> (-0.21%) 66.00 <0.00> (ø)
...server/master/processor/TaskResponseProcessor.java 87.50% <100.00%> (-0.50%) 3.00 <0.00> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.07% <0.00%> (-2.88%) 9.00% <0.00%> (-2.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347f05f...a9c8639. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

38.5% 38.5% Coverage
0.0% 0.0% Duplication

Technoboy-
Technoboy- approved these changes Apr 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

lgcareer
lgcareer approved these changes Apr 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lgcareer lgcareer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lgcareer lgcareer merged commit d6798c6 into apache:dev Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@lgcareer lgcareer lgcareer approved these changes

@lenboo lenboo Awaiting requested review from lenboo

@davidzollo davidzollo Awaiting requested review from davidzollo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qiaozhanwei @codecov-io @Technoboy- @lgcareer