Skip to content

Solve the failure to execute non-query sql#2413

Merged
lgcareer merged 4 commits intoapache:devfrom
zixi0825:sql_task_bug
Apr 15, 2020
Merged

Solve the failure to execute non-query sql#2413
lgcareer merged 4 commits intoapache:devfrom
zixi0825:sql_task_bug

Conversation

@zixi0825
Copy link
Copy Markdown
Member

What is the purpose of the pull request

Solve the failure to execute non-query sql

Brief change log

  • move resultSet = stmt.executeQuery() into SqlType.QUERY branch

Verify this pull request

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2413 into dev will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2413      +/-   ##
============================================
- Coverage     32.89%   32.87%   -0.03%     
+ Complexity     2275     2274       -1     
============================================
  Files           423      423              
  Lines         19839    19839              
  Branches       2366     2366              
============================================
- Hits           6527     6523       -4     
- Misses        12726    12729       +3     
- Partials        586      587       +1     
Impacted Files Coverage Δ Complexity Δ
...lphinscheduler/server/worker/task/sql/SqlTask.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...he/dolphinscheduler/common/thread/ThreadUtils.java 71.66% <0.00%> (-6.67%) 13.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5185d28...3ef9320. Read the comment docs.

Copy link
Copy Markdown
Contributor

@lgcareer lgcareer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lgcareer
Copy link
Copy Markdown
Contributor

You should fetch the new code and keep consisdent of current version.Then I merget this.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@lgcareer lgcareer merged commit f218370 into apache:dev Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants