Skip to content

update controllers with ApiException annotation#2401

Merged
qiaozhanwei merged 5 commits intoapache:devfrom
hgaol:dev
Apr 17, 2020
Merged

update controllers with ApiException annotation#2401
qiaozhanwei merged 5 commits intoapache:devfrom
hgaol:dev

Conversation

@hgaol
Copy link
Copy Markdown
Member

@hgaol hgaol commented Apr 12, 2020

What is the purpose of the pull request

Update all controllers with ApiException annotation. more details can refer to #2397 .

Brief change log

  • Update Controllers in api package
  • Optimise ApiExceptionHandler

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 12, 2020 •
edited
Loading

Codecov Report

Merging #2401 into dev will increase coverage by 0.66%.
The diff coverage is 2.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2401      +/-   ##
============================================
+ Coverage     33.47%   34.14%   +0.66%     
+ Complexity     2308     2306       -2     
============================================
  Files           423      423              
  Lines         19860    19464     -396     
  Branches       2375     2375              
============================================
- Hits           6649     6646       -3     
+ Misses        12633    12239     -394     
- Partials        578      579       +1
Impacted Files Coverage Δ Complexity Δ
...scheduler/api/controller/DataSourceController.java 3.63% <0.00%> (+1.43%) 2.00 <0.00> (ø)
...inscheduler/api/controller/ExecutorController.java 11.11% <0.00%> (+4.44%) 2.00 <0.00> (ø)
...phinscheduler/api/controller/LoggerController.java 20.00% <0.00%> (+7.50%) 2.00 <0.00> (ø)
...lphinscheduler/api/controller/LoginController.java 8.00% <0.00%> (+1.54%) 2.00 <0.00> (ø)
...hinscheduler/api/controller/ProjectController.java 6.45% <0.00%> (+3.00%) 2.00 <0.00> (ø)
...nscheduler/api/controller/SchedulerController.java 5.71% <0.00%> (+2.32%) 2.00 <0.00> (ø)
...nscheduler/api/controller/ResourcesController.java 2.08% <1.12%> (+0.91%) 2.00 <1.00> (ø)
...er/api/controller/ProcessDefinitionController.java 2.59% <1.44%> (+0.87%) 2.00 <1.00> (ø)
...uler/api/controller/ProcessInstanceController.java 4.00% <2.12%> (+1.50%) 2.00 <1.00> (ø)
...lphinscheduler/api/controller/UsersController.java 3.57% <2.38%> (+1.46%) 2.00 <1.00> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a8b56...5c8d65e. Read the comment docs.

@hgaol
Copy link
Copy Markdown
Member Author

hgaol commented Apr 13, 2020 •
edited
Loading

Hi, is there anyone can help me to review that? @dailidong @Technoboy-
Thanks in advance!

davidzollo
davidzollo approved these changes Apr 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

qiaozhanwei
qiaozhanwei approved these changes Apr 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@qiaozhanwei qiaozhanwei merged commit 4769bce into apache:dev Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

@qiaozhanwei qiaozhanwei qiaozhanwei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hgaol @codecov-io @davidzollo @qiaozhanwei