Skip to content

Adapting partial code(file name start with P #2) to the sonar cloud rule#2260

Merged
davidzollo merged 1 commit intoapache:devfrom
gabry-lab:fixSonarP2
Mar 26, 2020
Merged

Adapting partial code(file name start with P #2) to the sonar cloud rule#2260
davidzollo merged 1 commit intoapache:devfrom
gabry-lab:fixSonarP2

Conversation

@gabry-lab
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab commented Mar 21, 2020

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 21, 2020

Codecov Report

Merging #2260 into dev will decrease coverage by 1.52%.
The diff coverage is 28.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2260      +/-   ##
============================================
- Coverage     31.95%   30.42%   -1.53%     
- Complexity     1511     1663     +152     
============================================
  Files           311      337      +26     
  Lines         15402    17828    +2426     
  Branches       1864     2237     +373     
============================================
+ Hits           4922     5425     +503     
- Misses         9968    11846    +1878     
- Partials        512      557      +45
Impacted Files Coverage Δ Complexity Δ
...heduler/alert/manager/EnterpriseWeChatManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...duler/alert/template/impl/DefaultHTMLTemplate.java 77.55% <ø> (ø) 13.00 <0.00> (+1.00)
...inscheduler/alert/utils/EnterpriseWeChatUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...apache/dolphinscheduler/alert/utils/FuncUtils.java 91.66% <ø> (ø) 5.00 <0.00> (ø)
...che/dolphinscheduler/api/ApiApplicationServer.java 33.33% <ø> (ø) 1.00 <0.00> (ø)
...scheduler/api/controller/AlertGroupController.java 3.57% <0.00%> (-0.52%) 2.00 <0.00> (ø)
...heduler/api/controller/DataAnalysisController.java 5.40% <0.00%> (ø) 2.00 <0.00> (ø)
...scheduler/api/controller/DataSourceController.java 2.19% <0.00%> (ø) 2.00 <0.00> (ø)
...inscheduler/api/controller/ExecutorController.java 6.25% <0.00%> (ø) 2.00 <0.00> (ø)
...uler/api/controller/ProcessInstanceController.java 2.43% <0.00%> (ø) 2.00 <0.00> (ø)
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8085e93...a1ece12. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 21, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

15.2% 15.2% Coverage
0.0% 0.0% Duplication

davidzollo
davidzollo approved these changes Mar 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit eef8bf4 into apache:dev Mar 26, 2020
@gabry-lab gabry-lab deleted the fixSonarP2 branch March 27, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabry-lab @codecov-io @davidzollo