Skip to content

Connection mode of adding Sid to Oracle#2254

Merged
davidzollo merged 9 commits intoapache:devfrom
liwenhe1993:issue-2205-dev
Mar 28, 2020
Merged

Connection mode of adding Sid to Oracle#2254
davidzollo merged 9 commits intoapache:devfrom
liwenhe1993:issue-2205-dev

Conversation

@liwenhe1993
Copy link
Copy Markdown
Member

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 21, 2020

Codecov Report

Merging #2254 into dev will increase coverage by 0.53%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2254      +/-   ##
============================================
+ Coverage     30.46%   30.99%   +0.53%     
- Complexity     1665     1690      +25     
============================================
  Files           337      338       +1     
  Lines         17830    17846      +16     
  Branches       2238     2240       +2     
============================================
+ Hits           5432     5532     +100     
+ Misses        11843    11741     -102     
- Partials        555      573      +18     
Impacted Files Coverage Δ Complexity Δ
...scheduler/api/controller/DataSourceController.java 23.07% <0.00%> (+20.87%) 8.00 <0.00> (+6.00)
...olphinscheduler/api/service/DataSourceService.java 11.65% <0.00%> (+10.99%) 8.00 <0.00> (+6.00)
.../org/apache/dolphinscheduler/common/Constants.java 82.35% <ø> (ø) 1.00 <0.00> (ø)
...e/dolphinscheduler/common/enums/DbConnectType.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...phinscheduler/dao/datasource/OracleDataSource.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...he/dolphinscheduler/common/thread/ThreadUtils.java 75.00% <0.00%> (-6.67%) 14.00% <0.00%> (-1.00%)
...che/dolphinscheduler/api/service/UsersService.java 74.59% <0.00%> (+0.32%) 65.00% <0.00%> (+1.00%)
...cheduler/api/service/ProcessDefinitionService.java 74.95% <0.00%> (+0.34%) 84.00% <0.00%> (+1.00%)
...rg/apache/dolphinscheduler/api/utils/PageInfo.java 41.66% <0.00%> (+2.77%) 7.00% <0.00%> (+2.00%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe5b31...e09ae18. Read the comment docs.

@davidzollo
Copy link
Copy Markdown
Contributor

Codecov Report

Merging #2254 into dev will decrease coverage by 1.54%.
The diff coverage is 27.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2254      +/-   ##
============================================
- Coverage     31.95%   30.41%   -1.55%     
- Complexity     1511     1665     +154     
============================================
  Files           311      338      +27     
  Lines         15402    17846    +2444     
  Branches       1864     2241     +377     
============================================
+ Hits           4922     5427     +505     
- Misses         9968    11862    +1894     
- Partials        512      557      +45     

Impacted Files Coverage Δ Complexity Δ
...heduler/alert/manager/EnterpriseWeChatManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...duler/alert/template/impl/DefaultHTMLTemplate.java 77.55% <ø> (ø) 13.00 <0.00> (+1.00)
...inscheduler/alert/utils/EnterpriseWeChatUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...apache/dolphinscheduler/alert/utils/FuncUtils.java 91.66% <ø> (ø) 5.00 <0.00> (ø)
...che/dolphinscheduler/api/ApiApplicationServer.java 33.33% <ø> (ø) 1.00 <0.00> (ø)
...scheduler/api/controller/AlertGroupController.java 3.57% <0.00%> (-0.52%) 2.00 <0.00> (ø)
...heduler/api/controller/DataAnalysisController.java 5.40% <0.00%> (ø) 2.00 <0.00> (ø)
...scheduler/api/controller/DataSourceController.java 2.19% <0.00%> (ø) 2.00 <0.00> (ø)
...inscheduler/api/controller/ExecutorController.java 6.25% <0.00%> (ø) 2.00 <0.00> (ø)
...nscheduler/api/controller/ResourcesController.java 1.33% <0.00%> (+<0.01%) 2.00 <0.00> (ø)
... and 136 more
Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6872a...3eeafb6. Read the comment docs.

please solve

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo
Copy link
Copy Markdown
Contributor

please solve Conflicting files, thx

# Conflicts:
#	dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/OracleDataSource.java
@davidzollo davidzollo linked an issue Mar 28, 2020 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 526e5c9 into apache:dev Mar 28, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

@chenxingchun , please test this PR when you free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]Connection mode of adding Sid to Oracle

3 participants