Skip to content

Adapting partial code(file name start with P #1) to the sonar cloud rule#2187

Merged
davidzollo merged 1 commit intoapache:devfrom
gabry-lab:fixSonarP_1
Mar 15, 2020
Merged

Adapting partial code(file name start with P #1) to the sonar cloud rule#2187
davidzollo merged 1 commit intoapache:devfrom
gabry-lab:fixSonarP_1

Conversation

@gabry-lab
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab commented Mar 15, 2020

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 15, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@61ebbf2). Click here to learn what that means.
The diff coverage is 18.51%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev    #2187   +/-   ##
======================================
  Coverage       ?   29.84%           
  Complexity     ?     1630           
======================================
  Files          ?      336           
  Lines          ?    17795           
  Branches       ?     2239           
======================================
  Hits           ?     5311           
  Misses         ?    11920           
  Partials       ?      564
Impacted Files Coverage Δ Complexity Δ
.../server/worker/task/processdure/ProcedureTask.java 0% <0%> (ø) 0 <0> (?)
...dolphinscheduler/dao/utils/PostgrePerformance.java 0% <0%> (ø) 0 <0> (?)
...hinscheduler/dao/datasource/PostgreDataSource.java 0% <0%> (ø) 0 <0> (?)
...hinscheduler/dao/upgrade/PostgresqlUpgradeDao.java 0% <0%> (ø) 0 <0> (?)
...nscheduler/service/permission/PermissionCheck.java 0% <0%> (ø) 0 <0> (?)
...r/common/utils/process/ProcessBuilderForWin32.java 46% <0%> (ø) 32 <0> (?)
...ler/common/utils/placeholder/PlaceholderUtils.java 66.66% <100%> (ø) 3 <1> (?)
...ache/dolphinscheduler/server/utils/ParamUtils.java 83.87% <80%> (ø) 9 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ebbf2...f675d9c. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 15, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

21.1% 21.1% Coverage
2.4% 2.4% Duplication

davidzollo
davidzollo approved these changes Mar 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 1658176 into apache:dev Mar 15, 2020
@gabry-lab gabry-lab deleted the fixSonarP_1 branch March 15, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabry-lab @codecov-io @davidzollo