Skip to content

fix typo#2093

Merged
davidzollo merged 1 commit intoapache:devfrom
white-infinity:fix_typo
Mar 5, 2020
Merged

fix typo#2093
davidzollo merged 1 commit intoapache:devfrom
white-infinity:fix_typo

Conversation

@white-infinity
Copy link
Copy Markdown
Contributor

@white-infinity white-infinity commented Mar 5, 2020

What is the purpose of the pull request

fix typo

Brief change log

fix taskAppId comment

Verify this pull request

This pull request is code cleanup without any test coverage.

davidzollo
davidzollo approved these changes Mar 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 6ec8554 into apache:dev Mar 5, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 5, 2020

Codecov Report

Merging #2093 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2093      +/-   ##
============================================
+ Coverage     33.14%   33.15%   +0.01%     
- Complexity     1553     1554       +1     
============================================
  Files           313      313              
  Lines         15529    15534       +5     
  Branches       1886     1886              
============================================
+ Hits           5147     5151       +4     
  Misses         9852     9852              
- Partials        530      531       +1
Impacted Files Coverage Δ Complexity Δ
...dolphinscheduler/server/worker/task/TaskProps.java 36.48% <ø> (ø) 19 <0> (ø) ⬇️
...he/dolphinscheduler/api/service/LoggerService.java 91.3% <0%> (-8.7%) 7% <0%> (-1%)
...he/dolphinscheduler/server/utils/AlertManager.java 2.91% <0%> (-0.06%) 2% <0%> (ø)
...java/org/apache/dolphinscheduler/dao/AlertDao.java 3.33% <0%> (-0.06%) 1% <0%> (ø)
...duler/alert/template/impl/DefaultHTMLTemplate.java 77.55% <0%> (ø) 12% <0%> (ø) ⬇️
...ler/server/master/runner/MasterTaskExecThread.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...dolphinscheduler/dao/entity/ProcessDefinition.java 37.97% <0%> (ø) 25% <0%> (ø) ⬇️
.../dolphinscheduler/dao/upgrade/MysqlUpgradeDao.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...e/dolphinscheduler/common/log/WorkerLogFilter.java 33.33% <0%> (ø) 2% <0%> (ø) ⬇️
...rg/apache/dolphinscheduler/dao/entity/UdfFunc.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f46ed...1f3ac44. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 5, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@white-infinity @codecov-io @davidzollo