Optimize ParameterUtils.curingGlobalParams() execution efficiency#2090
Merged
davidzollo merged 3 commits intoapache:devfrom Mar 5, 2020
Merged
Optimize ParameterUtils.curingGlobalParams() execution efficiency#2090davidzollo merged 3 commits intoapache:devfrom
davidzollo merged 3 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2090 +/- ##
======================================
Coverage ? 33.18%
Complexity ? 1555
======================================
Files ? 313
Lines ? 15532
Branches ? 1883
======================================
Hits ? 5155
Misses ? 9850
Partials ? 527
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
davidzollo
approved these changes
Mar 5, 2020
Contributor
davidzollo
left a comment
There was a problem hiding this comment.
good job，the code is very high quality
+1
looking forward to your next contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directly return null when
globalParamListis null or empty.Remove excess null check.