Skip to content

Upgrade curator version#2083

Merged
Technoboy- merged 4 commits intoapache:devfrom
gabry-lab:upgradeCuratorVersion
Mar 5, 2020
Merged

Upgrade curator version#2083
Technoboy- merged 4 commits intoapache:devfrom
gabry-lab:upgradeCuratorVersion

Conversation

@gabry-lab
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab commented Mar 5, 2020

#2020

the curator issue: apache/curator#297 may cause InterProcessMutex.acquire() hang, we'd better upgrade its version

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 5, 2020

Codecov Report

Merging #2083 into dev will decrease coverage by 3.17%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev   #2083      +/-   ##
===========================================
- Coverage     33.17%     30%   -3.18%     
- Complexity     1554    1559       +5     
===========================================
  Files           313     332      +19     
  Lines         15529   17190    +1661     
  Branches       1886    2132     +246     
===========================================
+ Hits           5152    5157       +5     
- Misses         9848   11504    +1656     
  Partials        529     529
Impacted Files Coverage Δ Complexity Δ
...nscheduler/service/zk/DefaultEnsembleProvider.java 100% <100%> (ø) 6 <2> (?)
...scheduler/alert/template/AlertTemplateFactory.java 42.85% <0%> (-14.29%) 2% <0%> (ø)
...he/dolphinscheduler/api/service/LoggerService.java 91.3% <0%> (-8.7%) 7% <0%> (-1%)
...olphinscheduler/service/queue/TaskQueueZkImpl.java 0% <0%> (ø) 0% <0%> (?)
...hinscheduler/service/quartz/cron/CycleFactory.java 0% <0%> (ø) 0% <0%> (?)
...inscheduler/service/quartz/ProcessScheduleJob.java 0% <0%> (ø) 0% <0%> (?)
...lphinscheduler/service/process/ProcessService.java 0% <0%> (ø) 0% <0%> (?)
...pache/dolphinscheduler/service/log/LogPromise.java 0% <0%> (ø) 0% <0%> (?)
.../dolphinscheduler/service/zk/AbstractZKClient.java 0% <0%> (ø) 0% <0%> (?)
...dolphinscheduler/service/zk/ZookeeperOperator.java 0% <0%> (ø) 0% <0%> (?)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3186545...a1d791e. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 5, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

11.1% 11.1% Coverage
0.0% 0.0% Duplication

qiaozhanwei
qiaozhanwei approved these changes Mar 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Technoboy-
Copy link
Copy Markdown
Contributor

Technoboy- commented Mar 5, 2020

version is compatible with zookeeper.
+1

@Technoboy- Technoboy- merged commit 7ed28af into apache:dev Mar 5, 2020
@gabry-lab gabry-lab deleted the upgradeCuratorVersion branch March 6, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiaozhanwei qiaozhanwei qiaozhanwei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gabry-lab @codecov-io @Technoboy- @qiaozhanwei