Skip to content

add workflow id, name for email content#2071

Merged
qiaozhanwei merged 4 commits intoapache:devfrom
Eights-Li:dev-feature
Mar 5, 2020
Merged

add workflow id, name for email content#2071
qiaozhanwei merged 4 commits intoapache:devfrom
Eights-Li:dev-feature

Conversation

@Eights-Li
Copy link
Copy Markdown
Contributor

@Eights-Li Eights-Li commented Mar 4, 2020

What is the purpose of the pull request

#464 add workflow id, name for email content

Brief change log

  • add workflow id, name for email content

@Eights-Li Eights-Li requested review from lenboo and lgcareer March 4, 2020 02:20
Jave-Chen
Jave-Chen reviewed Mar 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jave-Chen Jave-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage was ignored because of the the number of New Lines is less then 20.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 4, 2020

Codecov Report

Merging #2071 into dev will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2071      +/-   ##
============================================
+ Coverage     33.15%   33.18%   +0.03%     
- Complexity     1553     1555       +2     
============================================
  Files           313      313              
  Lines         15529    15534       +5     
  Branches       1886     1886              
============================================
+ Hits           5148     5155       +7     
+ Misses         9852     9849       -3     
- Partials        529      530       +1
Impacted Files Coverage Δ Complexity Δ
...java/org/apache/dolphinscheduler/dao/AlertDao.java 3.33% <0%> (-0.06%) 1 <0> (ø)
...he/dolphinscheduler/server/utils/AlertManager.java 2.91% <0%> (-0.06%) 2 <0> (ø)
...ler/server/master/runner/MasterTaskExecThread.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...scheduler/alert/template/AlertTemplateFactory.java 42.85% <0%> (-14.29%) 2% <0%> (ø)
...he/dolphinscheduler/common/thread/ThreadUtils.java 77.96% <0%> (+3.38%) 13% <0%> (ø) ⬇️
...he/dolphinscheduler/api/service/TenantService.java 73.91% <0%> (+5.21%) 21% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3277b90...6853673. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Jave-Chen
Jave-Chen approved these changes Mar 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jave-Chen Jave-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

qiaozhanwei
qiaozhanwei approved these changes Mar 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit b8014d9 into apache:dev Mar 5, 2020
@Eights-Li Eights-Li removed request for lenboo and lgcareer March 5, 2020 03:33
@Eights-Li Eights-Li deleted the dev-feature branch March 26, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jave-Chen Jave-Chen Jave-Chen approved these changes

@qiaozhanwei qiaozhanwei qiaozhanwei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Eights-Li @codecov-io @Jave-Chen @qiaozhanwei