Skip to content

fix ugly logger usage#2063

Merged
qiaozhanwei merged 2 commits intoapache:devfrom
gabry-lab:fixLogging
Mar 5, 2020
Merged

fix ugly logger usage#2063
qiaozhanwei merged 2 commits intoapache:devfrom
gabry-lab:fixLogging

Conversation

@gabry-lab
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab commented Mar 3, 2020

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 3, 2020 •
edited
Loading

Codecov Report

Merging #2063 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2063      +/-   ##
============================================
- Coverage     33.18%   33.14%   -0.04%     
  Complexity     1553     1553              
============================================
  Files           313      313              
  Lines         15529    15529              
  Branches       1886     1886              
============================================
- Hits           5153     5147       -6     
- Misses         9846     9852       +6     
  Partials        530      530
Impacted Files Coverage Δ Complexity Δ
...inscheduler/api/controller/ExecutorController.java 6.25% <0%> (ø) 2 <0> (ø) ⬇️
...heduler/api/controller/DataAnalysisController.java 5.4% <0%> (ø) 2 <0> (ø) ⬇️
...heduler/server/master/runner/MasterExecThread.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...he/dolphinscheduler/common/thread/ThreadUtils.java 71.18% <0%> (-6.78%) 12% <0%> (-1%)
...er/server/worker/task/AbstractCommandExecutor.java 40.1% <0%> (-2.04%) 14% <0%> (ø)
...he/dolphinscheduler/api/service/LoggerService.java 100% <0%> (+8.69%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf05de...fd59b06. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

qiaozhanwei
qiaozhanwei approved these changes Mar 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit d5c795b into apache:dev Mar 5, 2020
@gabry-lab gabry-lab deleted the fixLogging branch March 5, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wen-hemin wen-hemin wen-hemin left review comments

@qiaozhanwei qiaozhanwei qiaozhanwei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gabry-lab @codecov-io @qiaozhanwei @wen-hemin