Skip to content

fix ZKServer startup error#2062

Merged
qiaozhanwei merged 2 commits intoapache:devfrom
Technoboy-:dev
Mar 3, 2020
Merged

fix ZKServer startup error#2062
qiaozhanwei merged 2 commits intoapache:devfrom
Technoboy-:dev

Conversation

@Technoboy-
Copy link
Copy Markdown
Contributor

@Technoboy- Technoboy- commented Mar 3, 2020

  1. delete duplicate startLocalZkServer

@Technoboy- Technoboy- requested a review from qiaozhanwei March 3, 2020 03:57
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 3, 2020 •
edited
Loading

Codecov Report

Merging #2062 into dev will increase coverage by 2.29%.
The diff coverage is 62.59%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2062      +/-   ##
============================================
+ Coverage     30.84%   33.13%   +2.29%     
- Complexity     1382     1552     +170     
============================================
  Files           294      313      +19     
  Lines         15022    15529     +507     
  Branches       1810     1886      +76     
============================================
+ Hits           4633     5145     +512     
+ Misses         9930     9854      -76     
- Partials        459      530      +71
Impacted Files Coverage Δ Complexity Δ
...er/server/worker/task/AbstractCommandExecutor.java 40.1% <0%> (ø) 14 <0> (ø) ⬇️
...common/utils/placeholder/TimePlaceholderUtils.java 4.56% <0%> (ø) 3 <0> (ø) ⬇️
...dolphinscheduler/api/service/ResourcesService.java 79.66% <0%> (ø) 67 <0> (ø) ⬇️
...hinscheduler/common/utils/TaskParametersUtils.java 70% <0%> (-7.78%) 11 <0> (ø)
...er/server/master/runner/MasterSchedulerThread.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/dolphinscheduler/common/model/DependentItem.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...lphinscheduler/server/worker/task/TaskManager.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ler/common/utils/placeholder/PlaceholderUtils.java 66.66% <0%> (ø) 3 <0> (ø) ⬇️
.../dolphinscheduler/common/utils/ParameterUtils.java 57.57% <0%> (ø) 13 <0> (ø) ⬇️
.../dolphinscheduler/api/service/ExecutorService.java 31.87% <0%> (ø) 16 <0> (ø) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e0a66...d0f0ed4. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

qiaozhanwei
qiaozhanwei approved these changes Mar 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit fbf05de into apache:dev Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiaozhanwei qiaozhanwei qiaozhanwei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Technoboy- @codecov-io @qiaozhanwei