Skip to content

Fixbug i18n #2008#2035

Merged
davidzollo merged 4 commits intoapache:devfrom
wen-hemin:fixbug-i18n
Mar 2, 2020
Merged

Fixbug i18n #2008#2035
davidzollo merged 4 commits intoapache:devfrom
wen-hemin:fixbug-i18n

Conversation

@wen-hemin
Copy link
Copy Markdown
Contributor

@wen-hemin wen-hemin commented Feb 27, 2020

1.api return message add chinese content
2.fix naming error

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #2035 into dev will increase coverage by 0.37%.
The diff coverage is 99.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2035      +/-   ##
============================================
+ Coverage     31.97%   32.34%   +0.37%     
- Complexity     1512     1564      +52     
============================================
  Files           311      313       +2     
  Lines         15402    15963     +561     
  Branches       1864     1994     +130     
============================================
+ Hits           4925     5164     +239     
- Misses         9971    10268     +297     
- Partials        506      531      +25
Impacted Files Coverage Δ Complexity Δ
...scheduler/api/controller/DataSourceController.java 2.19% <0%> (ø) 2 <0> (ø) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100% <100%> (ø) 5 <3> (+1) ⬆️
...apache/dolphinscheduler/common/enums/TaskType.java 71.42% <0%> (-9.53%) 2% <0%> (ø)
...he/dolphinscheduler/api/service/LoggerService.java 91.3% <0%> (-8.7%) 7% <0%> (-1%)
...pache/dolphinscheduler/common/utils/FileUtils.java 17.58% <0%> (-1.1%) 7% <0%> (ø)
...hinscheduler/common/utils/TaskParametersUtils.java 72.97% <0%> (-0.72%) 22% <0%> (+11%)
...cheduler/api/service/ProcessDefinitionService.java 74.6% <0%> (-0.35%) 83% <0%> (-1%)
...phinscheduler/server/worker/task/AbstractTask.java 11.65% <0%> (-0.29%) 3% <0%> (+1%)
...scheduler/alert/template/AlertTemplateFactory.java 42.85% <0%> (ø) 2% <0%> (ø) ⬇️
...duler/server/worker/runner/TaskScheduleThread.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d6eee5...2593c46. Read the comment docs.

Jave-Chen
Jave-Chen reviewed Feb 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jave-Chen Jave-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the front-end interface need to be modified too?

Technoboy-
Technoboy- requested changes Feb 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait for updates

@wen-hemin
Copy link
Copy Markdown
Contributor Author

wen-hemin commented Mar 1, 2020

Does the front-end interface need to be modified too?

No need to modify

@wen-hemin wen-hemin requested a review from Technoboy- March 1, 2020 13:11
@wen-hemin
Copy link
Copy Markdown
Contributor Author

wen-hemin commented Mar 1, 2020

This PR is implemented based on the current code, Only English and Chinese messages is supported, I think it can meet the current demand.
Next step, will extract the message into the i18n properties file, this change is relatively large.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

99.1% 99.1% Coverage
0.0% 0.0% Duplication

Jave-Chen
Jave-Chen approved these changes Mar 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jave-Chen Jave-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 good job

compile failed for ui module, seems like need to upgrade maven plugin version.

Technoboy-
Technoboy- approved these changes Mar 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.
Please other committer helps to take a review

davidzollo
davidzollo approved these changes Mar 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 1ea4837 into apache:dev Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@davidzollo davidzollo davidzollo approved these changes

@Jave-Chen Jave-Chen Jave-Chen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wen-hemin @codecov-io @Technoboy- @davidzollo @Jave-Chen