Add e2e to create workflow case #2027
Merged
khadgarmage merged 26 commits intoapache:devfrom Feb 27, 2020
xingchun-chen:dev
Merged
Add e2e to create workflow case #2027khadgarmage merged 26 commits intoapache:devfrom xingchun-chen:dev
khadgarmage merged 26 commits intoapache:devfrom
xingchun-chen:dev
Conversation
# Conflicts: # e2e/src/test/java/org/apache/dolphinscheduler/base/BaseDriver.java # e2e/src/test/java/org/apache/dolphinscheduler/common/BrowserCommon.java # e2e/src/test/java/org/apache/dolphinscheduler/data/project/CreatWorkflowData.java # e2e/src/test/java/org/apache/dolphinscheduler/locator/project/CreateWorkflowLocator.java # e2e/src/test/java/org/apache/dolphinscheduler/page/project/CreateProjectPage.java # e2e/src/test/java/org/apache/dolphinscheduler/page/project/CreateWorkflowPage.java # e2e/src/test/java/org/apache/dolphinscheduler/testcase/project/CreateProjectTest.java # e2e/src/test/java/org/apache/dolphinscheduler/testcase/project/CreateWorkflowTest.java # e2e/testng.xml
Codecov Report
@@ Coverage Diff @@
## dev #2027 +/- ##
============================================
- Coverage 31.98% 31.96% -0.02%
+ Complexity 1512 1511 -1
============================================
Files 311 311
Lines 15402 15402
Branches 1864 1864
============================================
- Hits 4926 4923 -3
- Misses 9965 9973 +8
+ Partials 511 506 -5
Continue to review full report at Codecov.
|
# Conflicts: # e2e/src/test/java/org/apache/dolphinscheduler/base/BaseDriver.java
# Conflicts: # e2e/src/test/java/org/apache/dolphinscheduler/base/BaseDriver.java
# Conflicts: # e2e/src/test/java/org/apache/dolphinscheduler/base/BaseDriver.java
# Conflicts: # e2e/src/test/java/org/apache/dolphinscheduler/base/BaseDriver.java
# Conflicts: # e2e/src/test/java/org/apache/dolphinscheduler/base/BaseDriver.java
|
Kudos, SonarCloud Quality Gate passed!
|
khadgarmage
requested changes
Feb 27, 2020
Contributor
khadgarmage
left a comment
There was a problem hiding this comment.
Pls put the case to e2e test.
| public static final String INPUT_ADD_CUSTOM_PARAMETERS_VALUE = "selenium_parameter_delete_456"; | ||
|
|
||
| //create workflow title | ||
| public static final String WORKFLOW_TITLE = "创建流程定义 - DolphinScheduler"; |
Contributor
There was a problem hiding this comment.
Pls change to english content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds checkstyle plugin.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)