Support worker server to run bat script#2023
Conversation
1. Reimplement ProcessImpl.java, ProcessEnvironment.java and ProcessBuilder.java for Windows 2. Modify shell task code for windows 3. Add ASF License
Codecov Report
@@ Coverage Diff @@
## dev #2023 +/- ##
============================================
+ Coverage 32.06% 32.73% +0.67%
+ Complexity 1612 1599 -13
============================================
Files 316 316
Lines 16552 16100 -452
Branches 2114 2006 -108
============================================
- Hits 5308 5271 -37
+ Misses 10686 10273 -413
+ Partials 558 556 -2
Continue to review full report at Codecov.
|
|
This PR has a problem with npm can't build it. |
|
sonarcloud scanned some issues, you can deal with |
|
For now, npm build failed, dont merge. |
|
SonarCloud Quality Gate failed.
|
khadgarmage
left a comment
There was a problem hiding this comment.
+1 ut coverage is up
davidzollo
left a comment
There was a problem hiding this comment.
greate job，big feature
+1
| * @since 1.5 | ||
| */ | ||
|
|
||
| public class ProcessBuilderForWin32 { |
There was a problem hiding this comment.
@dailidong what's the different between this class and the internal class? I would prefer remove all duplicated document, emphasize the difference and link to ProcessBuilder's build if there is nothing changed. Also at the beginning of the class document, it is possibly required that we mention it is copied from openjdk with modification, which will help reduce legal risk.
|
|
||
| import java.util.*; | ||
|
|
||
| final class ProcessEnvironmentForWin32 extends HashMap<String,String> { |
|
|
||
| import static com.sun.jna.platform.win32.WinBase.STILL_ACTIVE; | ||
|
|
||
| public class ProcessImplForWin32 extends Process { |
Support worker server to run bat script
#2015