Skip to content

fix taskinstance.isSubprocess misjudgment#2007

Merged
Eights-Li merged 7 commits intoapache:devfrom
Eights-Li:dev-instance
Feb 28, 2020
Merged

fix taskinstance.isSubprocess misjudgment#2007
Eights-Li merged 7 commits intoapache:devfrom
Eights-Li:dev-instance

Conversation

@Eights-Li
Copy link
Copy Markdown
Contributor

What is the purpose of the pull request

#1984 fix taskinstance.isSubprocess misjudgment

Brief change log

  • fix taskinstance.isSubprocess
  • add processInstance UT

Verify this pull request

This pull request is already covered by existing tests, such as

  • api/service/ProcessInstanceServiceTest

Copy link
Copy Markdown
Contributor

@Jave-Chen Jave-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Eights-Li Eights-Li requested a review from lenboo February 27, 2020 00:42
Copy link
Copy Markdown
Contributor

@khadgarmage khadgarmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Eights-Li Eights-Li removed the request for review from lenboo February 27, 2020 06:08
@Eights-Li Eights-Li merged commit 84409b5 into apache:dev Feb 28, 2020
@Eights-Li Eights-Li deleted the dev-instance branch March 3, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants